Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This message wasn't being sent by the language server #3840

Merged
merged 2 commits into from
Jun 27, 2019
Merged

This message wasn't being sent by the language server #3840

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d48d17
This message wasn't being sent by the language server
bobbrow Jun 27, 2019
a19638a
Merge branch 'master' into bobbrow/fallbackmessage
sean-mcmanus Jun 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Extension/src/LanguageServer/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1155,7 +1155,7 @@ class DefaultClient implements Client {
util.setProgress(util.getProgressParseRootSuccess());
} else if (message.endsWith("No Squiggles")) {
util.setIntelliSenseProgress(util.getProgressIntelliSenseNoSquiggles());
} else if (message.endsWith("IntelliSense Fallback")) {
} else if (message.endsWith("Unresolved Headers")) {
let showIntelliSenseFallbackMessage: PersistentState<boolean> = new PersistentState<boolean>("CPP.showIntelliSenseFallbackMessage", true);
if (showIntelliSenseFallbackMessage.Value) {
ui.showConfigureIncludePathMessage(() => {
Expand All @@ -1170,8 +1170,8 @@ class DefaultClient implements Client {
case configJSON:
vscode.commands.getCommands(true).then((commands: string[]) => {
if (commands.indexOf("workbench.action.problems.focus") >= 0) {
vscode.commands.executeCommand("workbench.action.problems.focus");
}
vscode.commands.executeCommand("workbench.action.problems.focus");
}
});
this.handleConfigurationEditJSONCommand();
telemetry.logLanguageServerEvent("SettingsCommand", { "toast": "json" }, null);
Expand All @@ -1180,7 +1180,7 @@ class DefaultClient implements Client {
vscode.commands.getCommands(true).then((commands: string[]) => {
if (commands.indexOf("workbench.action.problems.focus") >= 0) {
vscode.commands.executeCommand("workbench.action.problems.focus");
}
}
});
this.handleConfigurationEditUICommand();
telemetry.logLanguageServerEvent("SettingsCommand", { "toast": "ui" }, null);
Expand Down