Add Rename UI #4277
Merged
Add Rename UI #4277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
September 17, 2019 11:47
…into coleng/rename_ui
michelleangela
suggested changes
Sep 19, 2019
|
|
||
| this.disposables.push(vscode.languages.registerReferenceProvider(documentSelector, new FindAllReferencesProvider(this))); | ||
|
|
||
| class RenameProvider implements vscode.RenameProvider { |
There was a problem hiding this comment.
Put RenameProvider in different file?
There was a problem hiding this comment.
All of these providers need to be in their own files. I'd like to do that in a subsequent PR, after Insiders.
| @@ -574,6 +598,128 @@ export class DefaultClient implements Client { | |||
| } | |||
| } | |||
| this.disposables.push(vscode.languages.registerWorkspaceSymbolProvider(new WorkspaceSymbolProvider(this))); | |||
|
|
|||
| class FindAllReferencesProvider implements vscode.ReferenceProvider { | |||
There was a problem hiding this comment.
Put FindAllReferencesProvider in different file?
There was a problem hiding this comment.
Same as above. The other 3 as well. But, there are some complications I'd like to address after Insiders.
added 6 commits
September 19, 2019 15:31
sean-mcmanus
approved these changes
Sep 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.