Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix squiggle config settings #4538

Merged
merged 5 commits into from
Nov 6, 2019
Merged

Conversation

michelleangela
Copy link
Contributor

@michelleangela michelleangela commented Nov 5, 2019

Issue:

Could not enable error squiggles in c_cpp_properties.json unless setting was set in both c_cpp_properties.json and settings.json.

Fix:
Fix logic that checks settings in c_cpp_properties.json and settings.json. Setting in c_cpp_properties.json takes precedence if it is not undefined.

@michelleangela michelleangela merged commit f83f82d into master Nov 6, 2019
@michelleangela michelleangela deleted the mimatias/config-squiggles branch November 8, 2019 00:12
@sean-mcmanus sean-mcmanus added this to the 0.26.2 milestone Nov 8, 2019
@michelleangela
Copy link
Contributor Author

Fixed in version 0.26.2-insiders, available at https://github.com/microsoft/vscode-cpptools/releases/tag/0.26.2-insiders.

@michelleangela michelleangela added fixed Check the Milestone for the release in which the fix is or will be available. Feature: Configuration An issue related to configuring the extension or IntelliSense Language Service labels Nov 12, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature: Configuration An issue related to configuring the extension or IntelliSense fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants