Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with disabled compiler path in config UI if none detected #4912

Merged
merged 3 commits into from
Jan 30, 2020

Conversation

Colengms
Copy link
Collaborator

@Colengms Colengms commented Jan 30, 2020

Addresses #4727, #4879

Keeps the hidden span in the HTML file for the purpose of localization, but builds a new option to display in the drop-down. (For some reason, it does not work to hide/show an option in the HTML file).

@michelleangela
Copy link
Contributor

For future and to make validation easier, would be nice to have screenshots of fix if there are UI changes.

@Colengms Colengms merged commit e01071a into master Jan 30, 2020
@Colengms Colengms deleted the coleng/issue4727 branch January 30, 2020 02:33
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants