Optionally enable backtick command substitution for pickRemoteProcess #5053
Conversation
|
|
Update useBacktickCommandSubstitution setting to window scope
| if (settings.useBacktickCommandSubstitution) { | ||
| substitutionBegin = `\``; | ||
| substitutionEnd = `\``; | ||
| escapedQuote = `\"`; |
There was a problem hiding this comment.
Does backtick substitution mean that we don't need to escape the \ symbol?
There was a problem hiding this comment.
Originally with the escaped \ the command failed with an unmatched " error. I've just looked into this again and it seems to actually be a quirk in csh where stuff in single quotes doesn't get expanded: Stack Overflow answer
| @@ -108,6 +109,16 @@ export class RemoteAttachPicker { | |||
| private getRemoteProcessCommand(): string { | |||
| let innerQuote: string = `'`; | |||
| let outerQuote: string = `"`; | |||
| let substitutionBegin: string = `$(`; | |||
There was a problem hiding this comment.
rename as parameterBegin and parameterEnd
|
We should probably delay checking this in until 0.27.0-insiders3 or 0.27.0. |
Renaming substitutionBegin and substiutionEnd to parameterBegin and parameterEnd
|
@bobbrow @WardenGnaw Should we name the setting something like C_Cpp.debugging.useBacktickCommandSubstitution or C_Cpp.debugger.useBacktickCommandSubstitution ? It seems like that would help avoid confusing it with the other settings that are mostly language service related. |
|
@Helloimbob We just checked in a big "enable strictNullChecks" change, which is probably causing the merge conflict. |
|
@WardenGnaw Can this be checked in for 0.27.0-insiders3? Should we rename the setting? |
|
I agree that it should be renamed to |
This adds an option to use the obsolete backtick (`) command substitution in the debugger's pickRemoteProcess shell command for use with remote shells (such as csh) which don't support $() substitution.
This fixes #4015