adding CppStandard version to clang_format_style #5351
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Colengms
approved these changes
Apr 23, 2020
|
We shouldn't update the description. Most users won't be using C++03, so the fact that internally we'll switch to using that for the "Visual Studio" style doesn't need to be described here. The description is meant as a baseline for users to copy to modify if they wanted to change it slightly. The fact that users could add a CppStandard that matches their language (and their installed clang-format version) to their clang-format styles might be useful to describe, but probably somewhere else in the docs (not sure where exactly). |
|
@sean-mcmanus should we just close this PR then? |
Yes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug fix: #3578