updateChannel fixes.

[sean-mcmanus]

I don't think these fixes need to go into 0.28.0. They're not regressions.

[michelleangela]

What was the issue of udpateChannel? What is the fix?

[sean-mcmanus]

What was the issue of udpateChannel? What is the fix?

There were multiple issues.

1. It doesn't check for a downgrade to non-insiders on startup, only when the setting changes.
2. There was a bug with the timer code that checks for a new insiders every hour.
3. It wasn't bypassing the autoUpdate check when the user manually switches the updateChannel (the thread discussion).

[bobbrow]

Just a few small things, then this is good to go.

Were we going to add the minimumSupportedVersionForInsidersUpgrades to cpptools.json as well so that we're not comparing against a hard coded version of VS Code? Is there an issue for that, or do we need to create one?

[sean-mcmanus]

Just a few small things, then this is good to go.

Were we going to add the minimumSupportedVersionForInsidersUpgrades to cpptools.json as well so that we're not comparing against a hard coded version of VS Code? Is there an issue for that, or do we need to create one?

You created an issue for that at #4873 . I was going to do that separately.