Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Join string arrays in env with the correct delimiter #5510

Merged
merged 6 commits into from
May 29, 2020
Merged

Join string arrays in env with the correct delimiter #5510

merged 6 commits into from
May 29, 2020

Conversation

kersson
Copy link
Contributor

@kersson kersson commented May 16, 2020

Fixes #5509.

@msftclas
Copy link

msftclas commented May 16, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@sean-mcmanus sean-mcmanus added this to the 0.29.0 milestone May 19, 2020
@Colengms Colengms mentioned this pull request May 27, 2020
Closed
@sean-mcmanus sean-mcmanus requested a review from a team May 28, 2020 18:58
michelleangela
michelleangela suggested changes May 29, 2020
View reviewed changes
Extension/src/common.ts Outdated Show resolved Hide resolved
@michelleangela michelleangela merged commit 64ecdb7 into microsoft:master May 29, 2020
@kersson kersson deleted the fix-env-join branch May 29, 2020 23:03
@kersson kersson mentioned this pull request May 30, 2020
Closed
@bobbrow bobbrow modified the milestones: 0.29.0, 0.28.2 Jun 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sean-mcmanus sean-mcmanus sean-mcmanus approved these changes

@Colengms Colengms Colengms approved these changes

@michelleangela michelleangela michelleangela approved these changes

@bobbrow bobbrow Awaiting requested review from bobbrow

@elahehrashedi elahehrashedi Awaiting requested review from elahehrashedi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.28.2
Development

Successfully merging this pull request may close these issues.

String arrays in env are not joined properly
6 participants
@kersson @msftclas @sean-mcmanus @michelleangela @Colengms @bobbrow