EditorConfig Support #5932
Merged
EditorConfig Support #5932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarik-brown
requested review from
Colengms,
sean-mcmanus and
bobbrow
and removed request for
Colengms
…into dev/t-tabro/editorconfig
…into dev/t-tabro/editorconfig
bobbrow
reviewed
Aug 15, 2020
bobbrow
reviewed
Aug 15, 2020
bobbrow
reviewed
Aug 17, 2020
…into dev/t-tabro/editorconfig
…ft/vscode-cpptools into dev/t-tabro/editorconfig
sean-mcmanus
approved these changes
Aug 18, 2020
…into dev/t-tabro/editorconfig
sean-mcmanus
approved these changes
Aug 19, 2020
sean-mcmanus
requested changes
Aug 19, 2020
That's handled on the native side. I could unregister the providers when disabled. That would be a little more efficient. |
sean-mcmanus
approved these changes
Aug 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial EditorConfig support for the TypeScript Side