-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create '.vscode' directory before creating 'tasks.json' #6065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elahehrashedi
commented
Sep 1, 2020
Extension/src/common.ts
Outdated
@@ -633,6 +640,18 @@ export function readFileText(filePath: string, encoding: string = "utf8"): Promi | |||
|
|||
/** Writes content to a text file */ | |||
export function writeFileText(filePath: string, content: string, encoding: string = "utf8"): Promise<void> { | |||
const folders = filePath.split(path.sep).slice(0, -1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
creating folders in the path
elahehrashedi
force-pushed
the
elrashed/4280
branch
from
September 1, 2020 20:50
a0d9bea
to
ba2155a
Compare
bobbrow
requested changes
Sep 1, 2020
sean-mcmanus
approved these changes
Sep 1, 2020
bobbrow
approved these changes
Sep 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugfix: #4280
this bug fix is merged with this code as well (there was a conflict): Adds a JSON parsing library for tasks.json #5954
In both of these below cases, the .vscode folder will be created if it doesn't exist (before creating tasks.json file):
a) running "Run and Debug"
or
b) running "C/C++ build and debug active file"
tested on VsCode v 1.48.2