Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'Build and Debug Active File' race condition with EngineLogs #6304

Merged
merged 3 commits into from
Oct 14, 2020
Merged

Fix 'Build and Debug Active File' race condition with EngineLogs #6304

merged 3 commits into from
Oct 14, 2020

Commits on Oct 13, 2020

  1. Fix 'Build and Debug Active File' race condition with EngineLogs 

    If users use 'Build and Debug Active File' with "engineLogging", the resolveDebugConfigurations will quickly switch to the output window and `${fileBasenameNoExtension}` will resolve to something similar to `./extension-output-#5`.

This may be a bug with VS Code determining the output window to be a file, but this will unblock users who need to enable engine logging for this scenario.
    @WardenGnaw
    WardenGnaw authored Oct 13, 2020
    Configuration menu
    Copy the full SHA
    8a01196 View commit details
    Browse the repository at this point in the history

  2. Update configurationProvider.ts

    @WardenGnaw
    WardenGnaw authored Oct 13, 2020
    Configuration menu
    Copy the full SHA
    1d7e3f7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into dev/waan/fixExtensionOutput5Error

    @WardenGnaw
    WardenGnaw authored Oct 13, 2020
    Configuration menu
    Copy the full SHA
    0615061 View commit details
    Browse the repository at this point in the history