[cppdbg] Support new sourceFileMap schema #6319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-mcmanus
requested changes
Oct 15, 2020
For cppdbg, sourceFileMap can be used for binding breakpoints.
If keeping with the old format "<source-path>":"<target-path>", it will
always be used for breakpoints.
If you use the new:
"<compile-path>" : {
"editorPath": "<target-path>",
"useForBreakpoints": true
}
The sourceMap will only be used for frame enumeration.
WardenGnaw
force-pushed
the
dev/waan/updateSourceFileMap
branch
from
0561c6e
to
3dcd805
Compare
sean-mcmanus
approved these changes
Oct 21, 2020
|
@WardenGnaw Is this supposed to be checked in for 1.1.0-insiders3? It's seemed to be mentioned in the changelog. |
|
Yep. This will need to be checked in or the new schema type will not launch the debugger since it currently assumes sourceFileMap's value is always a string |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For cppdbg, sourceFileMap can be used for binding breakpoints.
If keeping with the old format
"<source-path>":"<target-path>", it willalways be used for breakpoints.
If you use the new:
The sourceMap will only be used for frame enumeration.
Descriptions are from:
https://github.com/microsoft/MIEngine/blob/cc361a883dbb7e61de78054f838f2ea9d9f5e065/src/MICore/LaunchOptions.xsd#L603-L626