-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add intelliSenseUpdateDelay setting #6344
Conversation
This requires changes in the closed source part of the code that handles the IntelliSense update. |
Extension/package.nls.json
Outdated
@@ -134,6 +134,7 @@ | |||
"c_cpp.configuration.intelliSenseCachePath.description": "Defines the folder path for cached precompiled headers used by IntelliSense. The default cache path is \"%LocalAppData%/Microsoft/vscode-cpptools\" on Windows, \"$XDG_CACHE_HOME/vscode-cpptools/\" on Linux (or \"$HOME/.cache/vscode-cpptools/\" if XDG_CACHE_HOME is not defined), and \"$HOME/Library/Caches/vscode-cpptools/\" on Mac. The default path will be used if no path is specified or if a specified path is invalid.", | |||
"c_cpp.configuration.intelliSenseCacheSize.description": "Maximum size of the per-workspace hard drive space in megabytes (MB) for cached precompiled headers; the actual usage may fluctuate around this value. The default size is 5120 MB. Precompiled header caching is disabled when the size is 0.", | |||
"c_cpp.configuration.intelliSenseMemoryLimit.description": "Memory usage limit in megabytes (MB) of an IntelliSense process. The default limit is 4096 MB and the maximum limit is 16 GB. The extension will shutdown and restart an IntelliSense process when it exceeds the limit.", | |||
"c_cpp.configuration.intelliSenseUpdateDelay.description": "Controls the delay in milliseconds before intelliSense takes effect.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
intelliSense -> IntelliSense
Yeah, but it should be pretty trivial to replace the hardcoded value with the setting. |
Extension/package.json
Outdated
"type": "number", | ||
"default": 2000, | ||
"description": "%c_cpp.configuration.intelliSenseUpdateDelay.description%", | ||
"scope": "resource" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add
"minimum": 500,
"maximum": 3000
Extension/package.nls.json
Outdated
@@ -134,6 +134,7 @@ | |||
"c_cpp.configuration.intelliSenseCachePath.description": "Defines the folder path for cached precompiled headers used by IntelliSense. The default cache path is \"%LocalAppData%/Microsoft/vscode-cpptools\" on Windows, \"$XDG_CACHE_HOME/vscode-cpptools/\" on Linux (or \"$HOME/.cache/vscode-cpptools/\" if XDG_CACHE_HOME is not defined), and \"$HOME/Library/Caches/vscode-cpptools/\" on Mac. The default path will be used if no path is specified or if a specified path is invalid.", | |||
"c_cpp.configuration.intelliSenseCacheSize.description": "Maximum size of the per-workspace hard drive space in megabytes (MB) for cached precompiled headers; the actual usage may fluctuate around this value. The default size is 5120 MB. Precompiled header caching is disabled when the size is 0.", | |||
"c_cpp.configuration.intelliSenseMemoryLimit.description": "Memory usage limit in megabytes (MB) of an IntelliSense process. The default limit is 4096 MB and the maximum limit is 16 GB. The extension will shutdown and restart an IntelliSense process when it exceeds the limit.", | |||
"c_cpp.configuration.intelliSenseUpdateDelay.description": "Controls the delay in milliseconds before intelliSense takes effect.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"takes effect" -> "starts updating after a modification."
Extension/package.json
Outdated
"type": "number", | ||
"default": 2000, | ||
"description": "%c_cpp.configuration.intelliSenseUpdateDelay.description%", | ||
"scope": "resource" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "resource" should be "application".
@@ -1184,6 +1186,7 @@ export class DefaultClient implements Client { | |||
intelliSenseCachePath : settings_intelliSenseCachePath, | |||
intelliSenseCacheSize : settings_intelliSenseCacheSize, | |||
intelliSenseMemoryLimit : settings_intelliSenseMemoryLimit, | |||
intelliSenseUpdateDelay: settings_intelliSenseUpdateDelay, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be workspaceSettings.intelliSenseUpdateDelay if the scope is changed to "application".
I have PR with the change. |
all need fixed had done @sean-mcmanus |
Thanks. The setting is working with our binary changes for our pending 1.1.0-insiders3 -- we may have an update later this week. |
@tjx666 Can you sign this CLA? |
No description provided.