Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add intelliSenseUpdateDelay setting #6344

Merged
merged 5 commits into from
Oct 20, 2020
Merged

Conversation

tjx666
Copy link
Contributor

@tjx666 tjx666 commented Oct 18, 2020

No description provided.

@ghost
Copy link

ghost commented Oct 18, 2020

CLA assistant check
All CLA requirements met.

@tjx666
Copy link
Contributor Author

tjx666 commented Oct 18, 2020

@sean-mcmanus #6344

@michelleangela
Copy link
Contributor

michelleangela commented Oct 18, 2020

This requires changes in the closed source part of the code that handles the IntelliSense update.

@@ -134,6 +134,7 @@
"c_cpp.configuration.intelliSenseCachePath.description": "Defines the folder path for cached precompiled headers used by IntelliSense. The default cache path is \"%LocalAppData%/Microsoft/vscode-cpptools\" on Windows, \"$XDG_CACHE_HOME/vscode-cpptools/\" on Linux (or \"$HOME/.cache/vscode-cpptools/\" if XDG_CACHE_HOME is not defined), and \"$HOME/Library/Caches/vscode-cpptools/\" on Mac. The default path will be used if no path is specified or if a specified path is invalid.",
"c_cpp.configuration.intelliSenseCacheSize.description": "Maximum size of the per-workspace hard drive space in megabytes (MB) for cached precompiled headers; the actual usage may fluctuate around this value. The default size is 5120 MB. Precompiled header caching is disabled when the size is 0.",
"c_cpp.configuration.intelliSenseMemoryLimit.description": "Memory usage limit in megabytes (MB) of an IntelliSense process. The default limit is 4096 MB and the maximum limit is 16 GB. The extension will shutdown and restart an IntelliSense process when it exceeds the limit.",
"c_cpp.configuration.intelliSenseUpdateDelay.description": "Controls the delay in milliseconds before intelliSense takes effect.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intelliSense -> IntelliSense

@sean-mcmanus
Copy link
Collaborator

This requires changes in the closed source part of the code that handles the IntelliSense update.

Yeah, but it should be pretty trivial to replace the hardcoded value with the setting.

"type": "number",
"default": 2000,
"description": "%c_cpp.configuration.intelliSenseUpdateDelay.description%",
"scope": "resource"
Copy link
Collaborator

@sean-mcmanus sean-mcmanus Oct 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add

          "minimum": 500,
          "maximum": 3000

@@ -134,6 +134,7 @@
"c_cpp.configuration.intelliSenseCachePath.description": "Defines the folder path for cached precompiled headers used by IntelliSense. The default cache path is \"%LocalAppData%/Microsoft/vscode-cpptools\" on Windows, \"$XDG_CACHE_HOME/vscode-cpptools/\" on Linux (or \"$HOME/.cache/vscode-cpptools/\" if XDG_CACHE_HOME is not defined), and \"$HOME/Library/Caches/vscode-cpptools/\" on Mac. The default path will be used if no path is specified or if a specified path is invalid.",
"c_cpp.configuration.intelliSenseCacheSize.description": "Maximum size of the per-workspace hard drive space in megabytes (MB) for cached precompiled headers; the actual usage may fluctuate around this value. The default size is 5120 MB. Precompiled header caching is disabled when the size is 0.",
"c_cpp.configuration.intelliSenseMemoryLimit.description": "Memory usage limit in megabytes (MB) of an IntelliSense process. The default limit is 4096 MB and the maximum limit is 16 GB. The extension will shutdown and restart an IntelliSense process when it exceeds the limit.",
"c_cpp.configuration.intelliSenseUpdateDelay.description": "Controls the delay in milliseconds before intelliSense takes effect.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"takes effect" -> "starts updating after a modification."

"type": "number",
"default": 2000,
"description": "%c_cpp.configuration.intelliSenseUpdateDelay.description%",
"scope": "resource"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "resource" should be "application".

@@ -1184,6 +1186,7 @@ export class DefaultClient implements Client {
intelliSenseCachePath : settings_intelliSenseCachePath,
intelliSenseCacheSize : settings_intelliSenseCacheSize,
intelliSenseMemoryLimit : settings_intelliSenseMemoryLimit,
intelliSenseUpdateDelay: settings_intelliSenseUpdateDelay,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be workspaceSettings.intelliSenseUpdateDelay if the scope is changed to "application".

@sean-mcmanus
Copy link
Collaborator

This requires changes in the closed source part of the code that handles the IntelliSense update.

Yeah, but it should be pretty trivial to replace the hardcoded value with the setting.

I have PR with the change.

@tjx666
Copy link
Contributor Author

tjx666 commented Oct 20, 2020

all need fixed had done @sean-mcmanus

@sean-mcmanus
Copy link
Collaborator

all need fixed had done @sean-mcmanus

Thanks. The setting is working with our binary changes for our pending 1.1.0-insiders3 -- we may have an update later this week.

@sean-mcmanus
Copy link
Collaborator

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ tjx666 sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@tjx666 Can you sign this CLA?

@tjx666
Copy link
Contributor Author

tjx666 commented Oct 20, 2020

@sean-mcmanus ok

@sean-mcmanus sean-mcmanus merged commit 12feb81 into microsoft:master Oct 20, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants