Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extension's x64 binaries to run on Apple Silicon x64 emulator #6601

Merged
merged 3 commits into from
Dec 4, 2020

Conversation

xymeng16
Copy link
Contributor

@xymeng16 xymeng16 commented Dec 1, 2020

Since arm64 and x86 macOS should have identical C++ support and features, I simply modified the if-condition in the activation() function at main.ts to allow the extension to work on my M1-chip Macbook. Now it has worked for 1 week with no error.

@sean-mcmanus
Copy link
Collaborator

FYI, the cpptools and cpptools-srv binaries are built for x64, so they may run slower and/or use more battery via running in an emulated mode compared to native arm64 binaries would.

@WardenGnaw
Copy link
Member

Same with the debugger binaries.

The mono runtime shipped is built for macOS x64 and same with the lldb-mi that is built.

@michelleangela michelleangela changed the title Add support to Apple Silicon Allow extension's x64 binaries to run on Apple Silicon x64 emulator Dec 1, 2020
@michelleangela
Copy link
Contributor

Also note that some default IntelliSense configuration may need to be modified, as these settings are based on the host architecture, platform, and available compiler.

@xymeng16
Copy link
Contributor Author

xymeng16 commented Dec 2, 2020

It seems that cpptools and cpptools-srv are close-sourced (or I don't know where to fetch their code). Hope that native arm64 version binaries will be online soon. Thanks for all of your work!

@sean-mcmanus sean-mcmanus merged commit 8dd2efd into microsoft:master Dec 4, 2020
@sean-mcmanus
Copy link
Collaborator

@xymeng16 We're tracking that with #6595 .

@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants