Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement addNodeAddonIncludePaths #6731

Merged
merged 11 commits into from
Jan 14, 2021
Merged

implement addNodeAddonIncludePaths #6731

merged 11 commits into from
Jan 14, 2021

Commits on Jan 1, 2021

  1. add addNodeAddonIncludePaths

    @bmacnaughton
    bmacnaughton committed Jan 1, 2021
    Configuration menu
    Copy the full SHA
    96c64c9 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2021

  1. partial review comments fixes

    @bmacnaughton
    bmacnaughton committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    e3797bd View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2021

  1. change scope to "application"

    @bmacnaughton
    bmacnaughton committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    9412739 View commit details
    Browse the repository at this point in the history

  2. make setting dynamic 

    - set at init and on changes
- always read nan/node-addon-api paths
    @bmacnaughton
    bmacnaughton committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    9fb66ac View commit details
    Browse the repository at this point in the history

  3. restructure addon include reads

    @bmacnaughton
    bmacnaughton committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    ae9b88d View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2021

  1. prompt for reload if no addon paths 

    - make nodeAddonMap a local
- fail silently
- add nodeAddonIncludesFound()
    @bmacnaughton
    bmacnaughton committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    1dc03a7 View commit details
    Browse the repository at this point in the history

  2. log relevant errors 

    - remove experimental artifact
    @bmacnaughton
    bmacnaughton committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    5b28559 View commit details
    Browse the repository at this point in the history

  3. use installed node for requires

    @bmacnaughton
    bmacnaughton committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    1eabe77 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2021

  1. remove incorrect include concat

    @bmacnaughton
    bmacnaughton committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    0b3c932 View commit details
    Browse the repository at this point in the history

  2. quote pathToNode

    @bmacnaughton
    bmacnaughton committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    892987c View commit details
    Browse the repository at this point in the history

  3. address review issues 

    - remove unused flag
- avoid unnecessary work
- handle alternate include setting path
    @bmacnaughton
    bmacnaughton committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    04fc19c View commit details
    Browse the repository at this point in the history