Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new "console" launch config for cppvsdbg #6794

Merged
merged 6 commits into from
Jan 16, 2021
Merged

Conversation

WardenGnaw
Copy link
Member

This PR adds new console support for the cppvsdbg debug type.

This removes the legacy 'externalConsole' flag with 'console'.
Console has four enums:

  • internalConsole: Output to the VS Code Debug Console. This doesn't
    support reading console input (ex:Console.ReadLine)
  • integratedTerminal: VS Code's integrated terminal
  • externalTerminal: External terminal that can be configured via user
    settings
  • newExternalWindow: Console applications will be launched in their own
    external console window which will end when the application stops.
    Non-console applications will run without a terminal, and
    stdout/stderr will be ignored

@gregg-miskelly

This PR adds new console support for the cppvsdbg debug type.

This removes the legacy 'externalConsole' flag with 'console'.
Console has four enums:
- internalConsole: Output to the VS Code Debug Console. This doesn't
  support reading console input (ex:Console.ReadLine)
- integratedTerminal: VS Code's integrated terminal
- externalTerminal: External terminal that can be configured via user
  settings
- newExternalWindow: Console applications will be launched in their own
  external console window which will end when the application stops.
  Non-console applications will run without a terminal, and
  stdout/stderr will be ignored.
Copy link
Member

@gregg-miskelly gregg-miskelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@sean-mcmanus sean-mcmanus requested a review from a team January 15, 2021 23:25
Extension/package.json Outdated Show resolved Hide resolved
Extension/package.nls.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants