Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify "Configure Task" behavior for multiroot #7315

Merged
merged 4 commits into from
Apr 12, 2021
Merged

Conversation

elahehrashedi
Copy link
Contributor

Consider this multi-root workspace:
image

if I want to configure a new task for a .cpp file in Root3, the API shows the Root1 task to the user:
image

with this change, root3 options will be available to the user (it still shows other workspace roots' tasks as well, but at least it is better than only showing the root1).
image

For a complete solution, we are waiting for vscode response. follow from here: #6804 and microsoft/vscode#120133

@elahehrashedi elahehrashedi requested review from bobbrow and a team April 7, 2021 23:46
@elahehrashedi elahehrashedi changed the title change task scope to Workspace Modify "Configure Task" behavior for multiroot Apr 7, 2021
@bobbrow bobbrow added this to the 1.4.0 milestone Apr 8, 2021
@elahehrashedi elahehrashedi added the fixed Check the Milestone for the release in which the fix is or will be available. label Apr 12, 2021
@elahehrashedi elahehrashedi merged commit 57f9e1e into main Apr 12, 2021
@WardenGnaw
Copy link
Member

nit: Please use Squash and merge instead of the merge commit unless each commit is an independent feature or bug fix.
image

E,g. linter error fix would not be for the whole main branch, just to the PR
image

@michelleangela michelleangela deleted the ella/taskScope branch April 12, 2021 21:51
@michelleangela michelleangela modified the milestones: 1.4.0, 1.3.0 Apr 12, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed Check the Milestone for the release in which the fix is or will be available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants