Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing default launch.json from "${workspaceFolder}" to "${fileDirname}" #7363

Merged
merged 6 commits into from
Apr 21, 2021
Merged

Changing default launch.json from "${workspaceFolder}" to "${fileDirname}" #7363

merged 6 commits into from
Apr 21, 2021

Conversation

HackintoshwithUbuntu
Copy link
Contributor

Bug fix: #7362
Old behavior:
incorrect values
New behavior:
image

@HackintoshwithUbuntu HackintoshwithUbuntu changed the title Changing default launch.json from "${workspaceFolder}" to "${fileDirname}" #7362 Changing default launch.json from "${workspaceFolder}" to "${fileDirname}" Apr 15, 2021
@ghost
Copy link

ghost commented Apr 15, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@HackintoshwithUbuntu
Copy link
Contributor Author

Seems like the Mac check had a network error?

@sean-mcmanus
Copy link
Collaborator

Seems like the Mac check had a network error?

Yeah, that's normal. Retry usually fixes it. We haven't investigated how to stop that from happening yet.

sean-mcmanus
sean-mcmanus requested changes Apr 15, 2021
View reviewed changes
Copy link
Collaborator

@sean-mcmanus sean-mcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the reference to ${workspaceFolder} in vscode-cpptools\Extension\src\LanguageServer\cppBuildTaskProvider.ts ? That code is hit with Configure Default Build Task.

@sean-mcmanus sean-mcmanus merged commit 3a83938 into microsoft:main Apr 21, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elahehrashedi elahehrashedi elahehrashedi approved these changes

@sean-mcmanus sean-mcmanus sean-mcmanus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@HackintoshwithUbuntu @sean-mcmanus @elahehrashedi