Change instances of OSX to macOS #7636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add x86_64 descriptor Whitespace stripping
|
|
sean-mcmanus
reviewed
Jun 1, 2021
sean-mcmanus
reviewed
Jun 1, 2021
sean-mcmanus
reviewed
Jun 1, 2021
sean-mcmanus
reviewed
Jun 1, 2021
Add x86_64 descriptor to ClangFormat
|
Thanks for your review @sean-mcmanus . I've changed Please let me know if you'd like to see any other changes. |
sean-mcmanus
approved these changes
Jun 1, 2021
michelleangela
approved these changes
Jun 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yesterday I noticed a popup that said
Downloading C/C++ language components (OS X). Apple renamed OS X to macOS a few years back, so I created this PR to change a few lingering instances ofOS XtomacOS.Changes
OS XtomacOSx86_64to description for x86_64 version of macOS cpptools, to make architecture clear in messagesQuestions
I noticed that
package.jsonuses botharm64andARM64. Should one of these be preferred over the other?Additionally, a few formats are used to communicate architecture in descriptions, e.g.
Linux / ARM64vsmacOS ARM64. Is one format preferred?