CUDA/CPP extensions #7726
Merged
CUDA/CPP extensions #7726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Missing dot: "cu" -> ".cu" * Useless uppercase ".C" before needed lowercase ".c" * Add same CPP extensions as here: https://github.com/microsoft/vscode-cpptools/blob/f82b1beaa0899b67685441325592690a9b664be9/Extension/src/LanguageServer/cppBuildTaskProvider.ts#L83
sean-mcmanus
approved these changes
Jun 21, 2021
| @@ -89,7 +89,7 @@ export async function getRawJson(path: string | undefined): Promise<any> { | |||
|
|
|||
| export function fileIsCOrCppSource(file: string): boolean { | |||
| const fileExtLower: string = path.extname(file).toLowerCase(); | |||
| return ["cu", ".C", ".c", ".cpp", ".cc", ".cxx", ".mm", ".ino", ".inl"].some(ext => fileExtLower === ext); | |||
| return [".cu", ".c", ".cpp", ".cc", ".cxx", ".c++", ".cp", ".tcc", ".mm", ".ino", ".ipp", ".inl"].some(ext => fileExtLower === ext); | |||
There was a problem hiding this comment.
I don't think so -- the input file is made lowercased and the function name is COrCpp. I don't see any C++ specific code that uses this function.
Colengms
approved these changes
Jun 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vscode-cpptools/Extension/src/LanguageServer/cppBuildTaskProvider.ts
Line 83 in f82b1be