-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Debugging on Alpine #8101
Conversation
Also a huge thanks to @Trass3r for the help and validation for this scenario. |
@@ -22,6 +23,16 @@ export function GetOSName(processPlatform: string | undefined): string | undefin | |||
} | |||
} | |||
|
|||
let _isAlpine: boolean | undefined; | |||
|
|||
export function IsAlpine(): boolean { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
functions should be named like isAlpine
Separate initialize method for Alpine until we can use the regular 'initialize' method. | ||
|
||
This enables attach and cppdbg for alpine without snippets or 'Build and Debug Active file' | ||
since we do not have a language service. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want one? What would it take for us to make it work? It would be better if we could just support the platform across the board.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets discuss this in our next meeting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well the current one is glibc-based.
Any updates? |
I see. But that will take a while. |
The activation of the extension depends on a bunch of the checks I added to disable the Language Service. The simple change is to fix the download for alpine machines since we download the export function PlatformsMatch(value: IPackage, info: PlatformInformation): boolean {
if (IsAlpine()) {
// Alpine needs to be explicitly stated in packages list in order to be downloaded.
return value.platforms && value.platforms.indexOf("alpine-linux") !== -1;
}
return !value.platforms || value.platforms.indexOf(info.platform) !== -1;
} |
@WardenGnaw Can this PR be abandoned, now that we support Alpine x64? |
Closing in favor for 1.8.0-insiders3 |
This enables Debug Launch/Attach for Linux-x64 Alpine.
Addresses debugging scenario for #4827
Added notes via
TODO(LS-alpine)
when Language Service has alpine support so we can have a full activation instead of a debugger only version.Tested using
remote-container
with the following configurations:Dockerfile
devcontainer.json