Remove support for 'online' binary downloads #8505
Conversation
…nto coleng/platform_specific_vsix2
…nto coleng/platform_specific_vsix2
…nto coleng/platform_specific_vsix2
Yes, we should remove it. Marketplace will not refer to us for information about pre-release versions. |
|
Does this PR make C++ extension VSIX packages on the marketplace platform-specific and offline? |
That is the plan. There are other pieces involved, in addition to this PR. |
…nto coleng/platform_specific_vsix2
…nto coleng/platform_specific_vsix2
… migration. Always send `acquisition` telemetry on activation.
Extension/src/main.ts
Outdated
| vscode.window.showInformationMessage(message, yes, no).then((selection) => { | ||
| switch (selection) { | ||
| case yes: | ||
| vscode.commands.executeCommand("workbench.extensions.installExtension", "ms-vscode.cpptools", { installPreReleaseVersion: true }); |
There was a problem hiding this comment.
What happens when there isn't a pre-release version available (e.g. when we release 1.8.0)? Does this just sign them up for insiders?
There was a problem hiding this comment.
That is my understanding. But, we should ask isidorn , just in case.
@isidorn , Can you comment on the behavior of installing with installPreReleaseVersion set to true? If there is no pre-release version available, or if the user is already using a more recent (non-pre-)release version, will it remain on the current version of the extension (and update to a pre-release when it becomes available) ?
There was a problem hiding this comment.
Passing installPreReleaseVersion flag will install the latest version, it can be a pre-release version or a release version, which ever is greater. If it happens that the latest version is a pre-release version then the user gets signed up to pre-release versions and gets auto update to pre-releases. Otherwise not, user gets auto updated only to release versions. In summary, this is not a flag that will sign up users to pre-releases. Hope it is clear.
Edit: You can make sure that user sign up to pre-release version by passing this flag and have a latest pre-release version that is always bigger than latest release version.
There was a problem hiding this comment.
@sandy081 @isidorn . It sounds like you understand what we are trying to do. Our Insiders release channel is a very important part of the process of validating our extension. However, it's a significant inconvenience to have to maintain an otherwise unnecessary prerelease version to ensure users are properly enrolled in receiving pre-release updates. We may need to open a feature request to address this, and it may delay us from adopting platform-specific VSIX's.
There was a problem hiding this comment.
@Colengms I think your request makes sense and I will add that feature soon - microsoft/vscode#139528
…nto coleng/platform_specific_vsix2
|
🚀 👏 🎉 |
This is to support platform-specific VSIX's - #8152
Removes the installation phase entirely. Real activation events are present in
package.json. Removed re-writing of package.json. Removed temporary command registrar. Removedruntime dependenciessection frompackage.json. Merged realActivation with activation. Removed use ofinstall.lock. Removed code to download platform-specific binaries. Removed all code that verified the correct architecture binaries were available, as that should now be handled by the marketplace.Also removed a check for CUDA support, which is no longer needed due to dependency on sufficiently recent version of VS Code.
Because this removed the Insider installation channel, this should not be checked in until right before the final insiders is released.