Add localized MD/HTML file for guidance when incompatible VSIX #8920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto coleng/detect_wrong_vsix
…nto coleng/detect_wrong_vsix
sean-mcmanus
requested changes
Feb 24, 2022
|
@Colengms Was the vsix supposed to be built with this? |
No, this is for 1.9.2 |
bobbrow
reviewed
Feb 24, 2022
sean-mcmanus
requested changes
Feb 28, 2022
sean-mcmanus
approved these changes
Feb 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add localized MD/HTML file for guidance when incompatible/mismatching VSIX is detected. This MD file is actually HTML, to enable localization.
Fixes an issue in which a redundant English version of each localized HTML file was included in the VSIX.
Adds a persistent var to suppress the warning when mismatched but compatible VSIX is detected.
I'm open to discussion on what to use as error/warning text and MD/HTML document contents.