Cache and reuse SSH passwords in the current session #9654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
xisui-MSFT
commented
Jul 27, 2022
•
xisui-MSFT
commented
- Cache password when one is entered.
- Reuse this password if the user match in later commands.
- If we get a password prompt for the same user and hostName in the same commands, we likely got a wrong password, so ask for it again.
- Cached passwords are persisted via SecretStorage in extension context.
- Show a progress notification when running deploy steps to avoid confusion during waiting.
xisui-MSFT
requested review from
WardenGnaw,
Colengms,
michelleangela,
bobbrow and
sean-mcmanus
WardenGnaw
approved these changes
Jul 28, 2022
WardenGnaw
approved these changes
Jul 29, 2022
sean-mcmanus
approved these changes
Jul 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.