Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSH Target Selector #9760

Merged
merged 15 commits into from
Sep 1, 2022
Merged

SSH Target Selector #9760

merged 15 commits into from
Sep 1, 2022

Conversation

xisui-MSFT
Copy link
Collaborator

@xisui-MSFT xisui-MSFT commented Aug 20, 2022 •
edited
Loading

The selector:
image

Connection infos are stored in SSH config files, which is supported natively by OpenSSH. All stored connections are listed in a view in the debug pane:
image

I'll schedule a demo session to show the experience and collect feedbacks.

@sean-mcmanus
Copy link
Collaborator

sean-mcmanus commented Aug 20, 2022 •
edited by bobbrow
Loading

This is for 1.13.0, right? The potential schedule is 1.12.2 (22nd), 1.12.3 (29th), 1.13.0 (31st).

@michelleangela michelleangela added this to the 1.13 milestone Aug 22, 2022
@michelleangela
Copy link
Contributor

This is for 1.13.0, right? The potential schedule is 1.22.2 (22nd), 1.22.3 (29th), 1.13.0 (5th).

I set the milestone to 1.13.0.

@michelleangela
Copy link
Contributor

I'll schedule a demo session to show the experience and collect feedbacks.

Will the demo be before or after this PR?

@xisui-MSFT
Copy link
Collaborator Author

I'll schedule a demo session to show the experience and collect feedbacks.

Will the demo be before or after this PR?

I'll forward you the invitation

bobbrow
bobbrow reviewed Aug 25, 2022
View reviewed changes
Extension/package.nls.json Outdated Show resolved Hide resolved
Extension/src/SSH/TargetsView/targetNodes.ts Outdated Show resolved Hide resolved
Extension/src/SSH/commandInteractors.ts Show resolved Hide resolved
michelleangela
michelleangela reviewed Aug 25, 2022
View reviewed changes
Extension/package.nls.json Outdated Show resolved Hide resolved
Extension/src/Debugger/extension.ts Outdated Show resolved Hide resolved
Extension/src/Debugger/extension.ts Outdated Show resolved Hide resolved
Extension/src/SSH/TargetsView/sshTargetsProvider.ts Show resolved Hide resolved
Extension/src/SSH/sshCommandToConfig.ts Outdated Show resolved Hide resolved
@xisui-MSFT xisui-MSFT mentioned this pull request Sep 1, 2022
Closed
@sean-mcmanus sean-mcmanus merged commit 03b3995 into main Sep 1, 2022
@sean-mcmanus sean-mcmanus deleted the dev/xisui/ssh_targets branch September 1, 2022 23:53
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bobbrow bobbrow bobbrow left review comments

@sean-mcmanus sean-mcmanus sean-mcmanus approved these changes

@michelleangela michelleangela michelleangela approved these changes

@WardenGnaw WardenGnaw Awaiting requested review from WardenGnaw

@Colengms Colengms Awaiting requested review from Colengms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13
Development

Successfully merging this pull request may close these issues.
4 participants
@xisui-MSFT @sean-mcmanus @michelleangela @bobbrow