Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

docker-in-docker-debian.sh library script hardcoded to use amd64 #840

Closed
philliphoff opened this issue Apr 28, 2021 · 1 comment
Closed
Assignees
Labels
feature-request Request for new features or functionality script-library

Comments

@philliphoff
Copy link
Contributor

philliphoff commented Apr 28, 2021

  • VSCode Version: N/A
  • Local OS Version: N/A
  • Name of Dev Container Definition with Issue:

script-library/docker-in-docker-debian.sh

The script hardcodes use of the amd64 packages for installing Docker. It should, at a minimum, allow the script user to optionally specify a different architecture (e.g. arm64), which would allow use of the script on Dev Container hosts such as the M1 Mac. It would be even better if the script detected the architecture of the running container and chose the appropriate version.

ddcc1

@2percentsilk 2percentsilk added the feature-request Request for new features or functionality label May 11, 2021
@Chuxel Chuxel self-assigned this Jun 24, 2021
@Chuxel
Copy link
Member

Chuxel commented Jul 2, 2021

The script has been updated!

@Chuxel Chuxel closed this as completed Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality script-library
Projects
None yet
Development

No branches or pull requests

3 participants