This repository has been archived by the owner on Nov 30, 2023. It is now read-only.
Begin updating script-library to support arm64 #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
//cc @joshspicer Since this technically affects the codespaces image. |
joshspicer
approved these changes
Jun 29, 2021
eitsupi
reviewed
Jun 29, 2021
…ners into clantz/apt-key-and-architecture
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for arm64 (and in some cases armhf) where possible to scripts in the library-scripts folder (related to #558). Given this drove a number of changes, I also picked up #511 and Terraform for #571. #840 is also resolved.
There's enough restructuring here that I want to get this in. All scripts work with x86_64.
Remaining issues:
gradle-debian.shin curl, that doesn't happen formaven-debian.shandjava-debian.shthat are nearly identical. I will raise a bug on this since it's not blocking to get this in.The
script-library/tests/regression/test.shscript can now use buildx to test cross-platform builds. More testing is needed on actual arm64 hardware.