Implementing download-edge to automate downloading and unzipping Edge files #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mliao95
force-pushed
the
user/milia/fix-unzip-script
branch
2 times, most recently
from
ff679cd to
bcda5e7
Compare
mliao95
commented
Jun 11, 2020
| * `[ZIP_FILE]:\src\out\Release\gen\devtools` | ||
| * copy the contents of the "devtools" folder and paste them into `c:\edge\src\out\Release\gen\devtools` | ||
| * Set the `EDGE_CHROMIUM_PATH` environment variable to `c:\edge\src` (assuming your drive is located at C:\) | ||
| * Download and Extract Edge source files |
There was a problem hiding this comment.
@vidorteg , when you get the chance, could you try out these new contributing steps and give me any feedback? Thanks
There was a problem hiding this comment.
I like the idea of having this process automated, but I would prefer to use npm instead of a new bash, users already know javascript so let's make contribution even easier.
mliao95
force-pushed
the
user/milia/fix-unzip-script
branch
from
9190712 to
bfbaf9c
Compare
mliao95
changed the title
added 2 commits
June 16, 2020 17:56
mliao95
force-pushed
the
user/milia/fix-unzip-script
branch
from
2ad5c37 to
e9f3872
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed file issue in https://thirdpartysource.microsoft.com/, removing unnecessary code associated with accommodating the directory structure issue with the previously uploaded ZIPs.
Adding section for Windows users to use the bash script to download Edge files.