Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a task provider for linting the whole workspace #410

Merged
merged 3 commits into from
Feb 23, 2018

Conversation

jackrl
Copy link

@jackrl jackrl commented Feb 22, 2018

No description provided.

@jackrl
Copy link
Author

jackrl commented Feb 22, 2018

Would there be a need for multiple tasks that could be made based on a configuration object?

I think being able to customize at least the arguments of the command would be nice.

Which one should I try implementing if any?

@dbaeumer
Copy link
Member

Very cool. Thanks a lot

@dbaeumer dbaeumer merged commit 09418a4 into microsoft:master Feb 23, 2018
@dbaeumer
Copy link
Member

@egamma FYI

@dbaeumer
Copy link
Member

@jackrl I did some tweaks to the code. The task provide is called whenever the Run Task command is executed. So there is not need to do anything special when the configuration changes other than creating the task and setting it to undefined.

@jackrl jackrl deleted the workspace-lint-task branch February 23, 2018 10:44
@jackrl
Copy link
Author

jackrl commented Feb 23, 2018

@dbaeumer Did your tweaks get lost somewhere? I don't see them on the master branch yet.

By the way, what about the possibility of configuring the task or creating multiple tasks base in config? Would that be a good feature in your opinion? I could work on that at some point.

@dbaeumer
Copy link
Member

@jackrl haven't checked them in yet since I noticed that you only supported a folder workspace and not a multi folder workspace. Needed to do more tweaks. Will check in soon.

@dbaeumer
Copy link
Member

Checked in the changes. I moved the code to a new file tasks.ts since to support multi folder more code was necessary. Let me know what you think.

@jackrl
Copy link
Author

jackrl commented Feb 23, 2018

It is much cleaner in its own file and creating the tasks when running the run task command is convenient too. I'll check it in more detail in a bit.

@jackrl
Copy link
Author

jackrl commented Feb 23, 2018

@dbaeumer Now it's great. Just what the previous manually added task did but easier and always ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants