-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a task provider for linting the whole workspace #410
Conversation
Would there be a need for multiple tasks that could be made based on a configuration object? I think being able to customize at least the arguments of the command would be nice. Which one should I try implementing if any? |
Very cool. Thanks a lot |
@egamma FYI |
@jackrl I did some tweaks to the code. The task provide is called whenever the Run Task command is executed. So there is not need to do anything special when the configuration changes other than creating the task and setting it to undefined. |
@dbaeumer Did your tweaks get lost somewhere? I don't see them on the master branch yet. By the way, what about the possibility of configuring the task or creating multiple tasks base in config? Would that be a good feature in your opinion? I could work on that at some point. |
@jackrl haven't checked them in yet since I noticed that you only supported a folder workspace and not a multi folder workspace. Needed to do more tweaks. Will check in soon. |
Checked in the changes. I moved the code to a new file tasks.ts since to support multi folder more code was necessary. Let me know what you think. |
It is much cleaner in its own file and creating the tasks when running the run task command is convenient too. I'll check it in more detail in a bit. |
@dbaeumer Now it's great. Just what the previous manually added task did but easier and always ready. |
No description provided.