Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Unify indentation in generated package.json #357

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

MatejKastak
Copy link
Contributor

Hi 👋

First of all thanks for this template, it was really useful for me in the past 👍 .

Last time I generated skeleton for vscode TS extension I noticed that package.json is always reformatted by prettier. There are inconsistencies between different package.json (across plugins, some use 2 spaces, some 4 spaces, some tabs, and some are mixed) and even directly in TS package.json indentation. Field name uses different indentation than displayName. See attached image.

image

Maybe some people will be against following prettier defaults (using spaces with tab width 2). But I think it's fairly popular tool and it's better to have the indentation consistent rather than random indentation.

Another way might be to add yes/No option at the end of generator dialog that will try to format the all relevant files after generation step is done.

This PR is just to kick of discussion if the maintainers would be open to such change. If so, I will try to properly test if I did not break any of the jsons.

@ghost
Copy link

ghost commented Jul 1, 2022

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ MatejKastak sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@aeschli aeschli requested review from aeschli and dbaeumer July 6, 2022 13:18
@aeschli aeschli added this to the July 2022 milestone Jul 6, 2022
@aeschli
Copy link
Contributor

aeschli commented Jul 6, 2022

Thanks for the PR, consistency if good!

@aeschli
Copy link
Contributor

aeschli commented Jul 6, 2022

@MatejKastak If you can accept the CLA (see https://github.com/apps/microsoft-cla) then we can push the PR.

@aeschli aeschli merged commit b437e84 into microsoft:main Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants