chore: Unify indentation in generated package.json #357
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
First of all thanks for this template, it was really useful for me in the past 👍 .
Last time I generated skeleton for vscode TS extension I noticed that
package.json
is always reformatted by prettier. There are inconsistencies between different package.json (across plugins, some use 2 spaces, some 4 spaces, some tabs, and some are mixed) and even directly in TS package.json indentation. Fieldname
uses different indentation thandisplayName
. See attached image.Maybe some people will be against following prettier defaults (using spaces with tab width 2). But I think it's fairly popular tool and it's better to have the indentation consistent rather than random indentation.
Another way might be to add
yes/No
option at the end of generator dialog that will try to format the all relevant files after generation step is done.This PR is just to kick of discussion if the maintainers would be open to such change. If so, I will try to properly test if I did not break any of the jsons.