Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Test Plan for December 2018 (0.8.0) #2164

Closed
ramya-rao-a opened this issue Dec 2, 2018 · 19 comments
Closed

Test Plan for December 2018 (0.8.0) #2164

ramya-rao-a opened this issue Dec 2, 2018 · 19 comments

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Dec 2, 2018 •
edited
Loading

If you got a notification from this issue, then you are part of the next update to the Go extension.
Thanks and Welcome!

Here I will be listing the features and the bug fixes that will go in the next update along with the the folks who logged the bugs/feature requests, those who upvoted it, and those who fixed it by sending PRs.

The idea is to get the folks behind this update to give the update a trial run before I release it.
Since I dont work with Go in my day job, I always feel that someone who does Go more than me can help in testing tremendously.

And when I say "test", you can do a minimum pass of just installing the update and then do nothing special other than going about using VS Code like you do everyday. Or you can test the feature you requested/implemented or the bug you logged/fixed. Or you can test all of the below. Every bit helps.

Drop in a comment in this issue after 2 or 3 days of installing the update with your findings.
@oneslash
Copy link
Contributor

oneslash commented Dec 3, 2018

#2134 - tested and works without error ✅

@nezorflame
Copy link
Contributor

nezorflame commented Dec 3, 2018 •
edited
Loading

#2121 - works as expected. The only thing missing right now would be some predefined key combination, e.g. Ctrl + F12 or Cmd + F12 (on macOS)

@JPMoresmau
Copy link
Contributor

JPMoresmau commented Dec 3, 2018 via email

@hummerd
Copy link
Contributor

hummerd commented Dec 3, 2018 •
edited
Loading

Some small fix for #2136 - #2167 :)

@segevfiner
Copy link
Contributor

#2121 - works as expected. The only thing missing right now would be some predefined key combination, e.g. Ctrl + F12 or Cmd + F12 (on macOS)

"Go to Type definition" is a builtin command in VS Code. Once we add a provider for it, it shows up/becomes available. I don't think it would be right for this extension to add a default short cut for it, might want to open an issue on VS Code itself. But they seem quite apprehensive when it comes to adding new default keybindings. There are some really silly missing default keybinding, for example: "Join Lines", that is only bound in macOS, despite showing up quite prominently in the documentation.

@hummerd
Copy link
Contributor

hummerd commented Dec 3, 2018

#2121 - works as expected. The only thing missing right now would be some predefined key combination, e.g. Ctrl + F12 or Cmd + F12 (on macOS)

It would be nice but:
Ctrl + F12 is already used for go to Implementation
And F12 is go to Definition
May be Ctrl + Shift + F12 ?

@karthikraobr
Copy link
Contributor

karthikraobr commented Dec 3, 2018 via email

@ramya-rao-a
Copy link
Contributor Author

Thanks everyone!

Regarding the keyboard shortcut request for the Go to Type Definition command, @segevfiner is right. This is not a command that is specific to the Go extension. It is a generic feature like Go to definition or Find all references. Extensions implement the providers which provide the data. VS Code takes care of triggering, keyboard shortcuts, navigation, UI etc.

I would suggest to add your own keybinding or create a feature request in the vscode repo if you have any good ideas for it.

@eternal-flame-AD
Copy link
Contributor

#1989 Looks great

@segevfiner
Copy link
Contributor

#2100 #2099 seems working.

#2121 - See #2166 #2171

@stamblerre
Copy link
Contributor

#1944 is working for me.

@willfaught
Copy link

willfaught commented Dec 5, 2018 •
edited
Loading

#1989 worked for me, although the dereferenced pointer value is labeled with a single colon, which might be a bug. See the b variable below:

screen shot 2018-12-04 at 11 42 02 pm

The debugger presentation of the pointer type seems incompatible with the other integral types (variables i and x in the example above). int(0) is displayed as i: 0, X(34) (where X is type X int) is displayed as x: 34, but (*int)(0xc0000160f8) is displayed as p: <*int>(0xc0000160f8). Maybe it makes sense to display it as just p: 0xc0000160f8 and let the user infer the type from the code like for the other variable types (and the presence of the drill down menu)?

@ramya-rao-a
Copy link
Contributor Author

ramya-rao-a commented Dec 5, 2018 •
edited
Loading

Thanks for reporting that @willfaught, can you log a new issue for that with the same details? We can use that for tracking the bug and possible fixes.

@ramya-rao-a ramya-rao-a mentioned this issue Dec 5, 2018
Closed
@willfaught willfaught mentioned this issue Dec 5, 2018
Closed
@willfaught
Copy link

@ramya-rao-a No problem. Done: #2176.

@nezorflame
Copy link
Contributor

nezorflame commented Dec 7, 2018 •
edited
Loading

@ramya-rao-a as for the #1944, I still have some issues.

With "go.toolsEnvVars": { "GO111MODULE": "on" }, gocode-gomod is being launched now, which is good.
But, it still fails to give suggestions to the package functions before you save the file.

Update: moved the details to the new issue mentioned below.

@nezorflame nezorflame mentioned this issue Dec 7, 2018
Closed
@nezorflame
Copy link
Contributor

nezorflame commented Dec 7, 2018 •
edited
Loading

I've created a new issue #2179 to investigate this particular problem.

@ramya-rao-a
Copy link
Contributor Author

@nezorflame Yes #1944 initially started out as completions don't work without saving the file with the package used atleast once, but it moved on to the GO111MODULE issue.

stamblerre/gocode#3 is tracking the original issue. I'll update #1944

@ssergiienko
Copy link

@ramya-rao-a Done, #2132 works fine now, thx.

@ramya-rao-a
Copy link
Contributor Author

Thanks everyone for all the help!
0.8.0 version of the Go extension has been released!

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests