Test Plan for April 2019 release #2410

ramya-rao-a · 2019-04-03T05:51:55Z

If you got a notification from this issue, then you are part of the next update to the Go extension which I plan to release early next week.
Thanks and Welcome!

Here, I am listing some of the features and the bug fixes that will go in the next update and for which I need some help in testing. Since I dont work with Go in my day job, I always feel that someone who does Go more than me can help in testing tremendously.

Also mentioned are the folks who logged the bugs/feature requests, those who upvoted it, and those who fixed it by sending PRs as these are the people with the most context on what the issue is.

And when I say "test", you can do a minimum pass of just installing the update and then do nothing special other than going about using VS Code like you do everyday. Or you can test the feature you requested/implemented or the bug you logged/fixed. Or you can test all of the below. Every bit helps.

Drop in a comment in this issue after 2 or 3 days of installing the update i.e the beta version with your findings.

Those using modules will get a prompt to use gopls, the language server from Google as it performs much better especially for code completions. Please try it out.

Go Modules support improvements

@calebdoxsey, @brainsnail, @yookoala, @samadadi, @jclc
- Add grammar for go.mod and go.sum files, thus providing syntax highlighting for them. Feature Request 1886 implemented with PR 2344
@FAQinghere, @nezorflame, @stevvooe
- Use goimports for formatting when using Go modules without the language server because goreturns(the default formatting tool) doesn't work with modules yet. Fixes Bug 2309
@nezorflame, @qjerome
- Fix build on save, install and debug features when GO111MODULE is set to on inside the GOPATH. Fixes Bug 2238 with commit 15f571e4
@stamblerre, @primalmotion, @mafredri
- Support gopls, the language server from Google as the one from Sourcegraph is no longer under active development. Also because gopls supports Go modules. PR 2383. Please read our updated README on language servers for the latest on what we recommend.

New features

@aswinmprabhu, @conradwt, @mgood, @Hades32, @jijeshmohan, @scriptnull, @carlca, @alwindoss
- Refactor commands to extract functions and variables using godoctor. Feature Request 588 implemented with PR 2139

Debugging improvements

@vladbarosan, @monkeyWie, @mxschmitt, @chadountain1
- Fix issue of debug file not being cleared after debugging on Windows. Fixes Bug 2265 with PR 2332
@jhendrixMSFT, @tcagan
- Fix variable display when debugging when the name has - in it. Fixes Bug 2328 with PR 2320
@aschade92, @mhr3
- You can now control whether global variables are shown or not in the variable pane while debugging by tweaking the showGlobalVariables property in the go.delveConfig setting. Feature Request 2323 implemented with PR 2351

Others

@FiloSottile, @vladbarosan
- Avoid prompts to re-compile Go tools when the go.toolsGopath is different between workspaces. PR 1589
@lggomez, @cassiobock
- Avoid moving to the next parameter in the Signature Help feature, when provided parameter value is a string with commas. Fixes Bug 1682 with PR 1738
@oneslash, @norilt
- Fix auto-completion when there is a string with // in the same line before the current position. Fixes Bug 2240 with PR 2316
@OneOfOne
- Clean up the temporary directory created by the Go extension when VS Code window is closed. Fixes Bug 2188 with commit 4a241f80
@EmpireJones
- Show the start of on save features in the output panel. Fixes Bug 1869 with commit 058eccf17
@elvizlai
- Ignore GOBIN when user has set go.toolsGopath setting. Fixes Bug 2339 with commit 9f99c30

The text was updated successfully, but these errors were encountered:

oneslash · 2019-04-03T07:55:15Z

fix for #2240 works fine for me

mafredri · 2019-04-03T08:26:38Z

This might actually be a gopls issue, I haven't investigated it further, but sometimes invalid code can cause code to be erased. It's as if we're trying to create a valid Go expression out of it.

Reporting it now as it can lead to a pretty poor user experience if released as-is.

Example (see trailing comma, not yet saved):

Save:

stamblerre · 2019-04-03T15:27:23Z

@mafredri: this is a gopls bug, if you want to open it there. 2 questions though - could you share the full contents of the file (I'm not able to reproduce), and what does gofmt do to this file?

nezorflame · 2019-04-03T16:14:14Z

@ramya-rao-a you didn't attach the released beta extension :)
I've built myself one from the 0.9.3-beta.7 tag, sharing it here in case someone needs it: Go-0.9.3-beta.7.zip

nezorflame · 2019-04-03T16:20:55Z

I can confirm that #2238 has been fixed.

primalmotion · 2019-04-03T16:26:23Z

With gopls, hovering on a structure shows the attributes and all on one line instead of being nicely formatted like before.

nezorflame · 2019-04-03T16:33:52Z

@primalmotion there's a fork of gopls by @saibing which has ported hover and some more functions from bingo, you might want to check it out: https://github.com/saibing/tools

mafredri · 2019-04-03T16:45:28Z

@stamblerre I can reproduce it, for example, by adding a comma at the end of this file/line: js/net/types_js.go#L11. It deletes tmp.Release().

When adding the comma to the file outside of vscode, and running gofmt, I see this error:

types_js.go:11:2: expected 1 expression

gofmt -w does not modify the file. I'll gather a trace and open a report on the Go issue tracker soon(ish).

ramya-rao-a · 2019-04-03T17:03:25Z

I've built myself one from the 0.9.3-beta.7 tag, sharing it here in case someone needs it

@nezorflame Thanks! I just realized the same. I clicked on the "Publish Release" button before the upload was complete :(. The release has been updated with the vsix file now.

@stamblerre Are there issues with a particular label somewhere where I can point folks to for known issues or features that are being tracked at? A few things I see are

Hover info, signature help, auto-completion should show docs as well
Hover info not formatted as expected
Auto-completion doesn't respect the setting go.useCodeSnippetsOnFunctionSuggest (This might need some work on my end to plumb through the settings)
Missing imports don't get added on file save (@stamblerre, I recall you mentioned that gopls has a on save hook where you run something similar to goimports to find missing imports and add them)

lucashtc · 2019-04-03T17:15:22Z

Using go mod here got incredibly fast.

FiloSottile · 2019-04-03T17:58:30Z

Formatting seems to be broken when working on the standard library. It works correctly for my other projects. When working on the standard library, even forcing a "Format Document" action does nothing. Nothing appears in the developer console.

This is my entire workspace settings.json, so I don't think it's caused by my wrokspace.

{
    "go.goroot": "~/go",
    "go.toolsGopath": "~/.vscode/godev",
    "spellright.documentTypes": [
        "git-commit"
    ],
    "[html]": {
        "editor.formatOnSave": false
    }
}

Manually running ~/.vscode/godev/bin/goimports -w works.

mxschmitt · 2019-04-03T18:04:03Z

Now the debug file will be deleted after I stop debugging. Good Job! @ramya-rao-a

FiloSottile · 2019-04-04T01:04:00Z

Turns out #2410 (comment) is a known gopls issue.

stamblerre · 2019-04-04T03:20:43Z

@ramya-rao-a: All of the gopls issues can be found here: https://github.com/golang/go/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+label%3Agopls. The only one I'm not sure of how to handle is getting the settings for function placeholders, but we can discuss that offline.

@FiloSottile: I actually just checked, but I was wrong earlier - gopls should work fine in the Go standard library. Looking at your settings, it doesn't seem like you have gopls enabled? Also getting imports on save with gopls does require the additional setting of:

"editor.codeActionsOnSave": {
    "source.organizeImports": true
},

kidlj · 2019-04-04T03:26:28Z

Hi, @ramya-rao-a

Here I have a problem of vscode-go-beta consuming too much memory.

I have a fresh new vscode-insiders with no custom settings. With only vscode-go-beta activated, the editor consumed about ~10G memory, and the log says [warning] UNRESPONSIVE extension host, 'ms-vscode.Go' took 98% of 5664.527ms.

Environment:
OS: macOS 10.14.4
Code version: 1.33.0-insider (1.33.0-insider)
vscode-go version: Go-0.9.3-beta.7.vsix

The PROFILE is here:

exthost-c2aaf2.cpuprofile.txt

nezorflame · 2019-04-04T13:25:21Z

@ramya-rao-a it seems like the goreturns is still being preferred instead of goimports for me in spite of change from #2309.
Removing "go.formatTool": "goimports" instantly makes the editor ask to install goreturns.
My setup:

macOS 10.14.4
Go 1.12.1
VSCode 1.32.3
vscode-go 0.9.3-beta.7
GO111MODULE=on is globally set in my ENV in .zprofile, so modules are enabled

primalmotion · 2019-04-04T17:52:38Z

I also have an issue with package completion. The choices are ... weird

It doesn't even show the standard json package. Is there a map overwriting itself somewhere?

ahmetb · 2019-04-04T17:58:44Z

This release solves my intellisense slowness with Go modules I reported at #2366.

ahmetb · 2019-04-04T18:14:17Z

I found a problem that some of my code gets deleted when I hit save (maybe gofmt issue?)

when my cursor is on context., I hit save and I get a few lines of code deleted (for some reason, the u remains):

shreyaskarnik · 2019-04-04T18:22:33Z

Environment:
OS: macOS 10.14.4
VSCode: 1.32.3
Go: go1.12.1 darwin/amd64

I found an issue when using gopls along with modules. I have all my dependencies resolved fine but see this in the editor

Here is output from gopls

stamblerre · 2019-04-04T19:19:40Z

For all of the people who are finding issues with gopls, it'd be really helpful if you could file them at golang.org/issue. It will be a lot easier for me to diagnose and resolve them that way.

Since gopls is still opt-in (even though it's the default language server, it's still an experimental setting), I don't think that all of the issues with gopls should necessarily be considered blockers, but I will do my best to resolve them ASAP.

conradwt · 2019-04-04T20:27:25Z

@shreyu86 Do you have a test case (i.e. runnable code sample) which exhibits this issue?

ramya-rao-a · 2019-04-05T04:25:49Z

@kidlj Please log a new issue with your go related setting changes and details from the Process explorer by running the command Developer -> Open Process Explorer

@nezorflame If you have removed the setting "go.formatTool": "goimports", then for the remainder of that VS Code session, the extension will assume that you wanted goreturns and so the prompt when it attempts to format. When reloaded or a new window is opened for a project using modules, you will be notified about the switch back to goimports. We can look into showing a notification when user chooses anything other than gofmt or goimports when using modules asking them not to do so. Please log a new issue for this.

@primalmotion Can you log a new issue for the issue with package completion? We can then see if those are coming from the extension or gopls and handle it appropriately

@shreyu86 I don't think that is from gopls. Diagnostics from the language server are not enabled by default. Please log a new issue.

nezorflame · 2019-04-05T09:21:18Z

@ramya-rao-a actually the warning is still there even after the VSCode restart.
I'll file a new issue.
EDIT: #2416

lggomez · 2019-04-05T16:34:51Z

I can confirm #1682 fix

calebdoxsey · 2019-04-05T19:39:06Z

I've seen no issues with "Feature Request 1886" (syntax highlighting for go.mod/go.sum).

shreyaskarnik · 2019-04-05T19:53:05Z

@ramya-rao-a the errors I was seeing went away when I switched off diagnostics

"go.languageServerExperimentalFeatures": {
    "diagnostics": false
  },

I can open a new issue if this is not being tracked.

stamblerre · 2019-04-05T20:03:02Z

@shreyu86: I don't think those errors were from gopls, like Ramya said. If you notice, on the right side of them, they say the source, which in the case of gopls, would be "LSP".

shreyaskarnik · 2019-04-05T21:18:59Z

@stamblerre Thanks for the response, #2410 (comment) made the errors I was seeing go away.

monkeyWie · 2019-04-06T05:34:30Z

@ramya-rao-a
The issue #2265 has been fixed. Thanks!

jclc · 2019-04-06T11:45:10Z

go.mod syntax highlighting doesn't work for comments right after some tokens unless there's a space in between. Seems to work for gofmt'd files. Doesn't provide paren completion like editing .go files would.

brainsnail · 2019-04-06T19:39:44Z

It looks like @jclc is right - these are the following scenarios where the comment highlighting doesn't work as expected without a space:

Doesn't recognize the comment

After the go keyword and version
After the module keyword and module

Recognizes the comment string, but breaks subsequent highlighting

After the replace keyword before a paren

Are there any other areas where you encountered this?

The paren autocompletion is also something I verified. I think this is driven by a setting - maybe we haven't flagged the .mod file as being applicable for autocomplete? Isn't the parenthesis driven by a snippet? That being said, I think that most users would be using the Go toolchain to generate their .mod files and wouldn't be manually updating them.

ramya-rao-a · 2019-04-06T19:42:43Z

@brainsnail Thanks for those screenshots, can you log a new issue for that?

@jclc, @brainsnail We will not be providing editing support for go.mod files, and so no auto-completion

brainsnail · 2019-04-06T19:53:40Z

@ramya-rao-a Yep, thanks Ramya!

This change will stop formatting from working on any file that does not parse. This is a temporary fix to handle the formatting problems mentioned here: microsoft/vscode-go#2410, but is not a long-term solution. Change-Id: Ie34b1876519832d6859db95fdcad7cc37a20b769 Reviewed-on: https://go-review.googlesource.com/c/tools/+/171019 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>

treeder · 2019-04-10T14:48:24Z

This doesn't seem to work for me to fill in missing imports:

"editor.codeActionsOnSave": {
    "source.organizeImports": true
},

I've also tried to increase the format on save value and that doesn't work either.

kyleferguson · 2019-04-12T11:30:58Z

Auto imports and auto complete for unimported seem to be broken now when working with modules. If I turn off the use language server setting, it seems to fix it but then goes back to being super slow.

nezorflame · 2019-04-12T11:34:18Z

@kyleferguson you could also use Go: Add import command from Palette to add required import. It works pretty well with gopls.

kyleferguson · 2019-04-12T11:48:20Z

Yea this does work. The auto import is really handy when working with large libraries though, like Kubernetes where you may have many definitions named the same thing. Auto import would correctly guess which one base on signatures etc.

nezorflame · 2019-04-12T11:56:06Z

Agreed, this needs to work.
@kyleferguson you could also try a fork of gopls by the author of bingo LSP who has ported some features to the gopls - it's a little unstable, but autoimport works there: https://github.com/saibing/tools

I use these settings with it (latest vscode-go beta release):

"go.useLanguageServer": true,
"go.languageServerExperimentalFeatures": {
    "autoComplete": true,
    "diagnostics": true,
    "documentSymbols": true,
    "findReferences": true,
    "format": true,
    "goToDefinition": true,
    "goToTypeDefinition": true,
    "hover": true,
    "rename": true,
    "signatureHelp": true,
    "workspaceSymbols": true,
},
"[go]": {
    "editor.defaultFormatter": "ms-vscode.Go",
    "editor.snippetSuggestions": "top",
    "editor.formatOnSave": true,
    "editor.codeActionsOnSave": {
        "source.organizeImports": true
    },
}

jclc · 2019-04-17T23:40:02Z

I'm running into this issue while running the beta:

When editing a file with the following contents, gopls repeatedly panics until the extension refuses to restart it.

package vulkan

func (r *Renderer) freeResources

gopls logs:
https://gist.github.com/jclc/fe0cafdc2682356e7f277e4ba10aa9a6

ramya-rao-a · 2019-04-23T19:17:39Z

Thanks for all the help everyone! The next version of the extension has been released (0.10.0)

If you see any issue with gopls, please check existing issues at https://github.com/golang/go/issues?q=is%3Aissue+is%3Aopen+label%3Agopls before logging a new one at https://github.com/golang/go/issues
If you see any other problems, please log a new issue in this repo

ramya-rao-a mentioned this issue Apr 3, 2019

Perfomance downgrade when using "go module" mode #2251

Closed

ramya-rao-a mentioned this issue Apr 5, 2019

Go modules projects makes intellisense and many other functionality is very slow #2366

Closed

nezorflame mentioned this issue Apr 5, 2019

goimports is not used as the default format tool in Go module-enabled environment #2416

Closed

brainsnail mentioned this issue Apr 6, 2019

go.mod - syntax highlighting for comments has some quirks #2423

Closed

ramya-rao-a closed this as completed Apr 23, 2019

vscodebot bot locked and limited conversation to collaborators Jun 7, 2019

Test Plan for April 2019 release #2410

Test Plan for April 2019 release #2410

Comments

ramya-rao-a commented Apr 3, 2019 • edited Loading

Go Modules support improvements

New features

Debugging improvements

Others

oneslash commented Apr 3, 2019

mafredri commented Apr 3, 2019

stamblerre commented Apr 3, 2019

nezorflame commented Apr 3, 2019

nezorflame commented Apr 3, 2019

primalmotion commented Apr 3, 2019

nezorflame commented Apr 3, 2019

mafredri commented Apr 3, 2019

ramya-rao-a commented Apr 3, 2019

lucashtc commented Apr 3, 2019

FiloSottile commented Apr 3, 2019 • edited Loading

mxschmitt commented Apr 3, 2019

FiloSottile commented Apr 4, 2019

stamblerre commented Apr 4, 2019

kidlj commented Apr 4, 2019 • edited Loading

nezorflame commented Apr 4, 2019 • edited Loading

primalmotion commented Apr 4, 2019

ahmetb commented Apr 4, 2019 • edited Loading

ahmetb commented Apr 4, 2019

shreyaskarnik commented Apr 4, 2019 • edited Loading

stamblerre commented Apr 4, 2019

conradwt commented Apr 4, 2019

ramya-rao-a commented Apr 5, 2019

nezorflame commented Apr 5, 2019 • edited Loading

lggomez commented Apr 5, 2019

calebdoxsey commented Apr 5, 2019

shreyaskarnik commented Apr 5, 2019

stamblerre commented Apr 5, 2019

shreyaskarnik commented Apr 5, 2019

monkeyWie commented Apr 6, 2019

jclc commented Apr 6, 2019

brainsnail commented Apr 6, 2019

ramya-rao-a commented Apr 6, 2019

brainsnail commented Apr 6, 2019

treeder commented Apr 10, 2019 • edited Loading

kyleferguson commented Apr 12, 2019

nezorflame commented Apr 12, 2019 • edited Loading

kyleferguson commented Apr 12, 2019

nezorflame commented Apr 12, 2019 • edited Loading

jclc commented Apr 17, 2019

ramya-rao-a commented Apr 23, 2019 • edited Loading

ramya-rao-a commented Apr 3, 2019 •

edited

Loading

FiloSottile commented Apr 3, 2019 •

edited

Loading

kidlj commented Apr 4, 2019 •

edited

Loading

nezorflame commented Apr 4, 2019 •

edited

Loading

ahmetb commented Apr 4, 2019 •

edited

Loading

shreyaskarnik commented Apr 4, 2019 •

edited

Loading

nezorflame commented Apr 5, 2019 •

edited

Loading

treeder commented Apr 10, 2019 •

edited

Loading

nezorflame commented Apr 12, 2019 •

edited

Loading

nezorflame commented Apr 12, 2019 •

edited

Loading

ramya-rao-a commented Apr 23, 2019 •

edited

Loading