Polish remote debug experience #2685
Conversation
|
|
There was a problem hiding this comment.
Hey @quoctruong
While @jhendrixMSFT and I review and test the changes in this PR, can you create a separate PR that has only changes related to the clean up that you have done here regarding types and interfaces?
I'd prefer to have them merged separately
src/debugAdapter/goDebug.ts
Outdated
| @@ -781,6 +776,11 @@ class GoDebugSession extends LoggingDebugSession { | |||
|
|
|||
| protected disconnectRequest(response: DebugProtocol.DisconnectResponse, args: DebugProtocol.DisconnectArguments): void { | |||
| log('DisconnectRequest'); | |||
| // For remote process, we have to issue a continue request | |||
| // before disconnecting. | |||
| if (this.delve.request === 'attach' && !this.delve.debugProcess) { | |||
There was a problem hiding this comment.
request can be launch and the user could be using the old of way doing remove debugging.
I would suggest adding a property isLocalDebugging on this.delve so that we can use that directly instead of checks like this
|
@ramya-rao-a PTAL |
|
@quoctruong when running dlv with |
|
@jhendrixMSFT Thanks for the catch! I put out a fix for the issue. Please give it another try. It should work now. |
|
OK that fixed it however there is still some squirrely behavior.
It's possible that this was a pre-existing issue, hard to tell since I can't detach/re-attach without these changes. But since this change enables the detach/re-attach scenario I feel it's worth fixing so that one can set breakpoints on re-attach. |
|
@jhendrixMSFT I believe this should fix it. I tried detaching and setting breakpoints a few times. Thanks for the catch! |
Fix a bug where setting breakpoint fails if the remote program is started through
dlvwith--continueswitch (#2690).Fix a bug where disconnecting (after attaching to) the remote program terminates it (#2592).
Fix a bug where setting breakpoint will fail if a breakpoint already exists (if dlv is started through multi client and another client sets the breakpoint).