Add basic multi-package mode #830
Conversation
|
@mattblagden, |
There was a problem hiding this comment.
- vet and cover on save features are broken
- consider making the setting an object where each feature(build/lint/vet) can be set to true or false separately
- consider skipping adding multipackage for test for now
- All in all, very excited and happy to see this PR. Keep up the good work :)
| @@ -213,8 +231,13 @@ export function check(filename: string, goConfig: vscode.WorkspaceConfiguration) | |||
|
|
|||
| if (!!goConfig['vetOnSave']) { | |||
| let vetFlags = goConfig['vetFlags'] || []; | |||
| let args = ['tool', 'vet', ...vetFlags]; | |||
| if (multiPackage) { | |||
There was a problem hiding this comment.
vet is not working regardless of the value of go.multipackage
go tool vet needs either filepath, package name/path or directory path
| @@ -484,6 +484,11 @@ | |||
| "type": "boolean", | |||
| "default": false, | |||
| "description": "If false, the import statements will be excluded while using the Go to Symbol in File feature" | |||
| }, | |||
| "go.multiPackage": { | |||
| "type": "boolean", | |||
There was a problem hiding this comment.
Currently, this flag affects build, lint, vet and test. There might be cases when users might want just a few of these to run on whole workspace. Example: There might be a lot of tests in the workspace and they might take time, so user might not want test to run on whole workspace but only build.
So instead of just having this setting as a simple boolean, we can have it as an object
"go.multiPackage": {
"type": "object",
"default": {
"build": false,
"test": false,
"lint": false,
"vet": false
},
"description": "Invoke build/lint/test commands recursively from the workspace root."
}
Thoughts?
| "go.multiPackage": { | ||
| "type": "boolean", | ||
| "default": false, | ||
| "description": "Invoke build/lint/test commands recursively from the workspace root." |
There was a problem hiding this comment.
vet is missing in the description
| } | ||
| } | ||
| if (multiPackage) { | ||
| args = args.concat('./...'); |
There was a problem hiding this comment.
coverOnSave is broken when multiPackage is set to true
To begin with, we can skip test from the multiPackage feature, and continue working on it in a separate PR
#816 talks about using test results from multiple packages for getting code coverage. We can use that to track multiPackage feature for test and code coverage
|
Would love to see this go in. Looks like some work is remaining, but +1 from me for this feature. |
|
Closing this in favor of #1023 |
Add an option to run lint/build/test on the entire workspace.
This is a very basic implementation that checks for the
go.multiPackageflag when inspecting the code. If in multi-package mode:.to./...See issue #589