Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect forceBuildBeforeLaunch setting even if autobuild is disabled #1380

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Respect forceBuildBeforeLaunch setting even if autobuild is disabled #1380

merged 1 commit into from
Aug 28, 2023

Conversation

testforstephen
Copy link
Contributor

This allows user to use Maven CLI for build to workaround the issue #1314

jdneo
jdneo approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that user disables both autobuild and forceBuildBeforeLaunch is aware of that he should build on his own. I think it should be very small amout of people. This change looks good to me.

@testforstephen testforstephen merged commit 2ae6677 into microsoft:main Aug 28, 2023
4 checks passed
@testforstephen testforstephen deleted the jinbo_build branch August 28, 2023 02:52
@testforstephen
Copy link
Contributor Author

Assuming that user disables both autobuild and forceBuildBeforeLaunch is aware of that he should build on his own. I think it should be very small amout of people. This change looks good to me.

agree. The default value of both the settings are true. If users explicitly disable it, they should know what they do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdneo jdneo jdneo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@testforstephen @jdneo