-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate high-sev CVEs by using Webpack@5 #800
Conversation
chunks: ['formatter-settings'] | ||
}), | ||
new HtmlWebpackInlineSourcePlugin(), | ||
new InlineChunkHtmlPlugin(HtmlWebpackPlugin, [/\.(js)$/]), | ||
new webpack.ProvidePlugin({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In webpack 5 automatic node.js polyfills are removed. Please refer to https://github.com/webpack/changelog-v5#automatic-nodejs-polyfills-removed and https://stackoverflow.com/questions/65018431/webpack-5-uncaught-referenceerror-process-is-not-defined
currently the newest version of |
84a3afc
to
0c807dc
Compare
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
fe40833
to
8020c08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
limit: 200000, | ||
esModule: false | ||
} | ||
type: 'asset', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here to remove deprecated url-loader
, the corresponding config can be found at https://webpack.js.org/guides/asset-modules/#general-asset-type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, so please play around it with your webviews. If everything is working well, feel free to approve this PR and we can merge it. (I cannot approve it as original author...)
Played the classpath configuration page with this PR and it works well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Played the formatter preview and it worked well.
This PR is a trial to adopt Webpack@5.
Here I upgrade some libs, to fix all CVEs with
high serverity
. BUT, it breaks the webviews, as html-inline plugin is no longer working with Webpack@5.@CsCherrYY FYI.