Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate high-sev CVEs by using Webpack@5 #800

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Conversation

Eskibear
Copy link
Member

@Eskibear Eskibear commented Nov 4, 2021

This PR is a trial to adopt Webpack@5.

Here I upgrade some libs, to fix all CVEs with high serverity. BUT, it breaks the webviews, as html-inline plugin is no longer working with Webpack@5.

@CsCherrYY FYI.

@Eskibear Eskibear requested a review from CsCherrYY November 4, 2021 06:08
chunks: ['formatter-settings']
}),
new HtmlWebpackInlineSourcePlugin(),
new InlineChunkHtmlPlugin(HtmlWebpackPlugin, [/\.(js)$/]),
new webpack.ProvidePlugin({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webpack.config.js Outdated Show resolved Hide resolved
@CsCherrYY
Copy link
Contributor

currently the newest version of react-dev-utils (11.0.4) includes some vulnerability issues and there is an issue tracking. See: facebook/create-react-app#11539. Let's keep eyes on it and update this PR.

@Eskibear Eskibear added this to the 0.19.0 milestone Nov 8, 2021
@Eskibear Eskibear mentioned this pull request Nov 11, 2021
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@CsCherrYY CsCherrYY marked this pull request as ready for review November 29, 2021 09:22
Copy link
Member Author

@Eskibear Eskibear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

limit: 200000,
esModule: false
}
type: 'asset',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here to remove deprecated url-loader, the corresponding config can be found at https://webpack.js.org/guides/asset-modules/#general-asset-type

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, so please play around it with your webviews. If everything is working well, feel free to approve this PR and we can merge it. (I cannot approve it as original author...)

@jdneo
Copy link
Member

jdneo commented Nov 30, 2021

Played the classpath configuration page with this PR and it works well.

Copy link
Contributor

@CsCherrYY CsCherrYY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Played the formatter preview and it worked well.

@Eskibear Eskibear merged commit 044cb95 into main Dec 1, 2021
@Eskibear Eskibear deleted the upgrade-webpack branch December 1, 2021 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants