feat: use custom toString() methods to generate object descriptions #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connor4312
commented
Jun 8, 2022
| } | ||
|
|
||
| for (const [key, value] of Object.entries(this)) { | ||
| if (typeof value === 'object' && value && !String(this.toString).includes('[native code]')) { |
There was a problem hiding this comment.
This detection is a bit ugly. Not sure if there's a more clever way to do this. Simply this.toString === Object.prototype.toString isn't enough because that also incorrectly stringifies boxed types, errors, and arrays.
connor4312
force-pushed
the
feat/to-string-object-descriptions
branch
from
9633741 to
44f2dd3
Compare
hediet
previously approved these changes
Jun 8, 2022
hediet
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1284