fix: make heap snapshot graph a panel instead of an editor #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not valid to open a file directly versus focusing a single element. Make it a webview panel instead to avoid the usability issue. For #175
rzhao271
approved these changes
Apr 4, 2024
|
@connor4312 I just updated to v1.0.9 and the open file dialog issue is fixed but clicking on the graph icons I see the raw json rather than the graph
|
|
You'll also need to be on Insiders, as the table is a built-in extension and not marketplace updatable. I should fix that to prevent users getting the updated flame graph code on stable to avoid this situation... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not valid to open a file directly versus focusing a single element. Make it a webview panel instead to avoid the usability issue.
Fixes #175