Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter Notebook Behavior Differences in VS Code vs VS Code Insiders #6045

Closed
amitktripathi opened this issue Jun 1, 2021 · 12 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@amitktripathi
Copy link

amitktripathi commented Jun 1, 2021

I recently gave VS Code Insiders a try and its impressive. The main reason I was trying Insider edition because I could not use Python extensions in Jupyter Notebook in VS Code. Interestingly I can do those in Jupyter Notebook in VS Code Insiders edition. However, I am finding the Markdown cells in VS Code insiders behaving strangely.

Few issues in VS Code Insiders while using Jupyter Notebook:

  1. The rendered fonts are very small and I am not sure what way to control/change them (In VSCode, the font followed 'Font Family'
  2. The markdown does not execute without manually pressing ctrl+alt+enter . In VS Code, this occurred as soon as the markdown cell was unselected
  3. While I see that there are more than just python and markdown cell options now, however switching between these two is not happening as smoothly (using escape and then M or Y does not produce intended results of switching between markdown and python)
  4. While not the biggest issue, the delete cell button is very close to other buttons in cell menu. I liked the layout in VS Code where delete cell button was separate and minimized accidental deletion of cell.

Using VS Code 1.56.2

Using VS Code Insiders 1.57

VS Code - 1.56.2
VS Code Insiders - 1.57
Windows 10

(If this report has incorrect format, I apologize. First time posting issue/feedback on git)

@IanMatthewHuff
Copy link
Member

@amitktripathi Currently VSCode-insiders contains our new UI that we will be slowly rolling out into stable over the next releases. Thanks for providing the feedback on it. I believe that we already have an issue covering the markdown not executing, but not on the other issues. We can look into these changes.

@IanMatthewHuff
Copy link
Member

Just for a clarification or two. For Rendered fonts you mean fonts in the notebook output, correct? Font family (and all other editor setting should still control the input code cells).

@amitktripathi
Copy link
Author

Just for a clarification or two. For Rendered fonts you mean fonts in the notebook output, correct? Font family (and all other editor setting should still control the input code cells).

@IanMatthewHuff That is correct. The font used in the markdown cell during editing is the one specified by Font Family. However, after the cell execution or stop editing, the font utilized are too small (my preference). I am not aware of any setting to modify fonts (family and size). Actually, it may be just my preference (or may be others too), can the the font styles in markdown be specified in separate setting than that from Font Family

Also, thank you for looking into other issues.

@chandresh
Copy link

chandresh commented Jun 3, 2021

I found some other issues using Jupytor notebook with VS Code Insiders: https://github.com/microsoft/vscode-jupyter/issues/6094

@greazer
Copy link
Member

greazer commented Jun 6, 2021

M & Y shortcut is covered by #4438

@joyceerhl
Copy link
Contributor

M & Y work for me today. They are actually contributed by VS Code.
image

image

@berdakh
Copy link

berdakh commented Jun 11, 2021

Just for a clarification or two. For Rendered fonts you mean fonts in the notebook output, correct? Font family (and all other editor setting should still control the input code cells).

@IanMatthewHuff That is correct. The font used in the markdown cell during editing is the one specified by Font Family. However, after the cell execution or stop editing, the font utilized are too small (my preference). I am not aware of any setting to modify fonts (family and size). Actually, it may be just my preference (or may be others too), can the the font styles in markdown be specified in separate setting than that from Font Family

Also, thank you for looking into other issues.

The rendered font size is too small for me as well. To increase the font size, I used the Customize UI tool. I hope it will be possible to increase the font size within the VC code setting soon.

The font size is almost the same between the stop editing vs editing:

2021-06-12_164815

@mtsitzer
Copy link

Also hoping for a setting to be able to change the output/rendered size.

Input size:
image

Output/Rendered size:
image

The output/rendered size is considerably smaller than the input text and is definitely a dissatisfier for me.

@IanMatthewHuff
Copy link
Member

I just filed an issue upstream on VS Code for the markdown text size rendering. I don't believe that there is a current setting for this.
microsoft/vscode#126294

@mtsitzer
Copy link

mtsitzer commented Jun 17, 2021

Something else I noticed: the rendering of error messages when running code cells is also noticeably harder to read than it used to be.

Note that I am using VSCode default Light Theme (Light+).

Interactive Python:
image

Notebook:
image

Is there currently a way to make this a bit easier on the eyes? (the green is not great in either the interactive view or the notebook, but in the notebook the green is unreadable)

@IanMatthewHuff
Copy link
Member

@mtsitzer That's a good suggestion, would you mind filing that as a new issue? The feedback here is great, but when multiple issues get into one thread it can be a bit hard to track the resolution on our side.

@greazer greazer added the bug Issue identified by VS Code Team member as probable bug label Aug 7, 2021
@greazer
Copy link
Member

greazer commented Aug 8, 2021

Reading through, it appears that all of the issues noted have been addressed or reference another open issue. So, closing this one. If there was something missed, please open a new issue. Thank you!

@greazer greazer closed this as completed Aug 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

7 participants