Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difficulty Reading Error Message Text in New Notebook Output Rendering #127110

Closed
mtsitzer opened this issue Jun 22, 2021 · 6 comments
Closed

Difficulty Reading Error Message Text in New Notebook Output Rendering #127110

mtsitzer opened this issue Jun 22, 2021 · 6 comments

Comments

@mtsitzer
Copy link

The rendering of error messages when running code cells is difficult to read (using new Jupyter Notebook extension update) than it used to be.

Note that I am using VSCode default Light Theme (Light+).

Interactive Python:
image

Notebook:
image

Is there currently a way to make this a bit easier on the eyes? (the green is not great in either the interactive view or the notebook, but in the notebook the green is unreadable). In addition, the yellow "+" is also very hard to see.

Originally posted by @mtsitzer in microsoft/vscode-jupyter#6045 (comment)

@rchiodo
Copy link
Contributor

rchiodo commented Jun 22, 2021

@rebornix is VS code applying a foreground color to output cells?

Seems like a similar issue with applying any CSS to results.

@rchiodo
Copy link
Contributor

rchiodo commented Jun 22, 2021

We should be applying the terminal styles to the ansi code translation? At least we did in the old webview implementation.

@greazer greazer transferred this issue from microsoft/vscode-jupyter Jun 24, 2021
@rebornix rebornix self-assigned this Jun 28, 2021
@rebornix
Copy link
Member

@misolori didn't we remove the default background color for the outputs?

@rebornix rebornix removed their assignment Jun 28, 2021
@miguelsolorio
Copy link
Contributor

Yes, we no longer show the output background color by default.

@miguelsolorio
Copy link
Contributor

miguelsolorio commented Jul 27, 2021

This is no longer an issue since we removed the output background color a few versions ago:

CleanShot 2021-07-27 at 09 21 47@2x

@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants
@rebornix @rchiodo @mtsitzer @miguelsolorio and others