Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmless renames needed for the variable viewer #10068

Merged
merged 1 commit into from
May 19, 2022

Conversation

sadasant
Copy link
Contributor

These renames are needed for #9665

They should be harmless!

@sadasant sadasant requested a review from a team as a code owner May 19, 2022 18:28
@sadasant sadasant self-assigned this May 19, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #10068 (687e4bb) into main (ce71b9d) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##            main   #10068   +/-   ##
======================================
  Coverage     64%      64%           
======================================
  Files        216      216           
  Lines      10056    10056           
  Branches    1611     1611           
======================================
+ Hits        6505     6507    +2     
+ Misses      3027     3026    -1     
+ Partials     524      523    -1     
Impacted Files Coverage Δ
src/platform/debugger/debugLocationTracker.ts 93% <ø> (ø)
...tform/debugger/debugLocationTrackerFactory.node.ts 92% <100%> (ø)
src/platform/errors/errorHandler.ts 63% <0%> (+<1%) ⬆️

@sadasant sadasant merged commit e6f523d into microsoft:main May 19, 2022
@sadasant sadasant deleted the harmless-renames branch May 19, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants