Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiplexingDebugService for the web #10070

Merged
merged 3 commits into from
May 23, 2022

Conversation

sadasant
Copy link
Contributor

Migrated the multiplexingDebugService to the web, for #9665

This PR gets us closer to the meatier section of the migration of the variable views. The highlight in this case is making the IJupyterDebugService optional in the multiplexingDebugService.

Feedback appreciated!

@sadasant sadasant requested a review from a team as a code owner May 19, 2022 19:29
Copy link
Contributor

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could instead rename multiplexingDebugService.node.ts to multiplexingDebugService.ts and just have the node specific parts optional.

@sadasant
Copy link
Contributor Author

@rchiodo can do! thank you for the feedback 👍

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2022

Codecov Report

Merging #10070 (1e93d5d) into main (e6f523d) will decrease coverage by 0%.
The diff coverage is 28%.

@@          Coverage Diff           @@
##            main   #10070   +/-   ##
======================================
- Coverage     64%      64%   -1%     
======================================
  Files        216      215    -1     
  Lines      10060    10047   -13     
  Branches    1613     1619    +6     
======================================
- Hits        6508     6456   -52     
- Misses      3028     3064   +36     
- Partials     524      527    +3     
Impacted Files Coverage Δ
src/platform/debugger/multiplexingDebugService.ts 47% <28%> (ø)
src/platform/export/exportUtil.node.ts 73% <0%> (-13%) ⬇️
src/platform/common/process/proc.node.ts 77% <0%> (-3%) ⬇️
...c/platform/common/process/pythonDaemonPool.node.ts 74% <0%> (-2%) ⬇️
src/platform/common/process/baseDaemon.node.ts 49% <0%> (-2%) ⬇️
src/platform/errors/errorHandler.ts 62% <0%> (-1%) ⬇️
src/platform/common/types.ts 100% <0%> (ø)
src/platform/export/types.ts 100% <0%> (ø)
src/platform/logging/types.ts 100% <0%> (ø)
src/platform/common/platform/types.ts 100% <0%> (ø)
... and 35 more

Copy link
Contributor

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor fixups.

@sadasant
Copy link
Contributor Author

@IanMatthewHuff @rchiodo thank you so much for your kind and thoughtful reviews! I will polish this up on Monday. 🙏 thanks again!

@sadasant sadasant merged commit b8ae8c5 into microsoft:main May 23, 2022
@sadasant sadasant deleted the multiplexing-the-web branch May 23, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants