Hide progress message after export completes #10122
Conversation
| @@ -39,24 +39,7 @@ export class FileConverter extends FileConverterBase implements IFileConverter { | |||
| ); | |||
| } | |||
|
|
|||
| override async performExport( | |||
There was a problem hiding this comment.
We were overriding it just to change one argument in a method call of the base class.
Rather than copying and pasting the code from the base class, I've added a new method that can be overridden to change the behaviour of what happens when opening the file.
| @@ -107,10 +108,17 @@ export class FileConverter implements IFileConverter { | |||
| } | |||
There was a problem hiding this comment.
@rchiodo this method was identical in the child class, except for the line 110, we were adding a new argument.
Tomorrow if we have more formats then we need to copy code from the parent class into this child class, which isn't good
| @@ -107,10 +108,17 @@ export class FileConverter implements IFileConverter { | |||
| } | |||
|
|
|||
| if (target) { | |||
| await this.exportFileOpener.openFile(format, target, true); | |||
There was a problem hiding this comment.
Moved this code into a different method so that the child classes can do what they like (change behaviour on how files are opened after its exported)
Fixes #9112