Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable IW in web #10131

Merged
merged 7 commits into from
May 26, 2022
Merged

Enable IW in web #10131

merged 7 commits into from
May 26, 2022

Conversation

amunger
Copy link
Contributor

@amunger amunger commented May 25, 2022

Fixes #9717

One notable command that was not enabled is execute selection since it uses an execution service to get the applicable block of code from a selection and I haven't taken the time to convert that yet.

@amunger amunger requested a review from a team as a code owner May 25, 2022 19:01
@codecov-commenter
Copy link

codecov-commenter commented May 25, 2022

Codecov Report

Merging #10131 (8a6ea17) into main (284bea7) will decrease coverage by 0%.
The diff coverage is 100%.

❗ Current head 8a6ea17 differs from pull request most recent head b25346e. Consider uploading reports for the commit b25346e to get more accurate results

@@          Coverage Diff          @@
##           main   #10131   +/-   ##
=====================================
- Coverage    55%      55%   -1%     
=====================================
  Files       203      203           
  Lines      9238     9239    +1     
  Branches   1490     1490           
=====================================
- Hits       5090     5089    -1     
- Misses     3744     3748    +4     
+ Partials    404      402    -2     
Impacted Files Coverage Δ
src/platform/common/utils/localize.ts 98% <100%> (+<1%) ⬆️
src/platform/common/configSettings.ts 75% <0%> (-6%) ⬇️
...form/common/process/pythonExecutionFactory.node.ts 49% <0%> (-3%) ⬇️
...ommon/process/environmentActivationService.node.ts 43% <0%> (ø)
src/platform/common/cancellation.ts 53% <0%> (+3%) ⬆️
src/platform/common/platform/fileSystem.ts 53% <0%> (+5%) ⬆️
src/platform/logging/consoleLogger.ts 50% <0%> (+11%) ⬆️
src/platform/logging/outputChannelLogger.ts 50% <0%> (+11%) ⬆️

@rchiodo
Copy link
Contributor

rchiodo commented May 25, 2022

We should probably convert the interactive tests to also run for the web. I did that for ipywidget tests and remote tests. I think you could likely follow a similar pattern.

Copy link
Contributor

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we've introduced a breaking change to not have an active interpreter controller for IW

@amunger amunger requested a review from DonJayamanne May 26, 2022 16:52
@amunger amunger merged commit 981500b into main May 26, 2022
@amunger amunger deleted the dev/aamunger/webIW2 branch May 26, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support interactive window in web extension
5 participants