Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataViewer added to the webview serviceRegistry.web.ts #10495

Merged
merged 5 commits into from
Jun 18, 2022

Conversation

sadasant
Copy link
Contributor

Adding the DataViewer to the list of services loaded in the web.

I'm working on the rest of the changes for #9665 -- I'm really trying to minimize my changes per PR, both for the reviewers ❤️ and because it gets really complex to debug what is broken on the web when I do a bigger quantity of changes.

This PR does not have any negative impact in the web, as far as I could see.
Feedback always appreciated 🙏

@sadasant sadasant requested a review from a team as a code owner June 17, 2022 22:04
@sadasant sadasant self-assigned this Jun 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2022

Codecov Report

Merging #10495 (4fbfc65) into main (eb2d5c1) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##            main   #10495   +/-   ##
======================================
- Coverage     71%      71%   -1%     
======================================
  Files        467      467           
  Lines      28072    28072           
  Branches    4736     4736           
======================================
- Hits       19937    19935    -2     
- Misses      6249     6251    +2     
  Partials    1886     1886           
Impacted Files Coverage Δ
...nsion-side/dataviewer/dataViewerMessageListener.ts 100% <ø> (ø)
src/webviews/extension-side/webviewPanelHost.ts 87% <ø> (ø)
...c/webviews/extension-side/dataviewer/dataViewer.ts 58% <100%> (ø)
...ebviews/extension-side/plotting/plotViewer.node.ts 20% <100%> (ø)
...rc/webviews/extension-side/serviceRegistry.node.ts 100% <100%> (ø)
src/kernels/errors/jupyterInvalidKernelError.ts 62% <0%> (-38%) ⬇️
src/platform/common/cancellation.ts 59% <0%> (-4%) ⬇️
src/kernels/jupyter/session/jupyterSession.ts 72% <0%> (-3%) ⬇️
src/platform/api/kernelApi.ts 71% <0%> (-2%) ⬇️
src/kernels/errors/kernelErrorHandler.ts 62% <0%> (-1%) ⬇️
... and 7 more

@sadasant sadasant merged commit c925935 into microsoft:main Jun 18, 2022
@sadasant sadasant deleted the web-DataViewer branch June 18, 2022 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants