Rebornix/move debugger out of kernels #10870
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading through #10855, it seems that kernels/debugger is directly used in notebooks and interactive window and no other sub components in kernels actually rely on it (only exception is kernels/variables/debugVariable but that is still related to debugging).
This PR is an attempt to move debugging feature code into notebooks and it proved our hypothesis that debugging is a standalone feature, moving it out doesn't modify any other file in kernels. This also opens the door of reviewing debugging code in notebooks and interactive-window and see if they can be unified.
package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed).