Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize to handling of large outputs in notebooks #11350

Merged
merged 7 commits into from
Oct 13, 2022
Merged

Conversation

DonJayamanne
Copy link
Contributor

Fixes #11031

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2022

Codecov Report

Merging #11350 (c408927) into main (eaf40cb) will decrease coverage by 0%.
The diff coverage is 85%.

@@          Coverage Diff           @@
##            main   #11350   +/-   ##
======================================
- Coverage     62%      62%   -1%     
======================================
  Files        483      483           
  Lines      34224    34214   -10     
  Branches    5525     5523    -2     
======================================
- Hits       21490    21475   -15     
- Misses     10696    10697    +1     
- Partials    2038     2042    +4     
Impacted Files Coverage Δ
...c/kernels/execution/cellExecutionMessageHandler.ts 77% <85%> (-1%) ⬇️
src/kernels/execution/notebookUpdater.ts 88% <0%> (-8%) ⬇️
src/platform/common/cancellation.ts 64% <0%> (-4%) ⬇️
...rc/notebooks/controllers/controllerRegistration.ts 85% <0%> (-3%) ⬇️
src/kernels/jupyter/baseKernelConnectionWrapper.ts 35% <0%> (-3%) ⬇️
...c/platform/common/process/pythonDaemonPool.node.ts 78% <0%> (-2%) ⬇️
src/kernels/jupyter/jupyterKernelService.node.ts 72% <0%> (-2%) ⬇️
src/kernels/kernelDependencyService.node.ts 83% <0%> (-2%) ⬇️
src/kernels/common/baseJupyterSession.ts 80% <0%> (-1%) ⬇️
... and 4 more

@roblourens
Copy link
Member

🎉🎉🎉

@DonJayamanne DonJayamanne force-pushed the appendOutputItem branch 2 times, most recently from 50b785e to 20b7f95 Compare October 12, 2022 20:58
@DonJayamanne DonJayamanne merged commit 4b4df37 into main Oct 13, 2022
@DonJayamanne DonJayamanne deleted the appendOutputItem branch October 13, 2022 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VS Code crashes when running a cell that produces a lot of output
4 participants