Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prerelease checker notification #11527

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

IanMatthewHuff
Copy link
Member

Fixes #11477

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for feature-requests.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@IanMatthewHuff IanMatthewHuff marked this pull request as ready for review October 4, 2022 18:24
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2022

Codecov Report

Merging #11527 (d8919d1) into main (0271863) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##            main   #11527   +/-   ##
======================================
- Coverage     63%      63%   -1%     
======================================
  Files        477      476    -1     
  Lines      34182    34096   -86     
  Branches    5546     5537    -9     
======================================
- Hits       21605    21537   -68     
+ Misses     10518    10497   -21     
- Partials    2059     2062    +3     
Impacted Files Coverage Δ
src/platform/common/utils/localize.ts 76% <ø> (-1%) ⬇️
src/platform/serviceRegistry.node.ts 100% <ø> (ø)
.../notebooks/controllers/controllerDefaultService.ts 65% <0%> (-9%) ⬇️
...rc/platform/common/application/applicationShell.ts 24% <0%> (-4%) ⬇️
src/notebooks/telemetry/kernelTelemetry.ts 85% <0%> (-4%) ⬇️
src/kernels/installer/productInstaller.node.ts 78% <0%> (-2%) ⬇️
src/kernels/execution/cellExecution.ts 72% <0%> (-2%) ⬇️
...otebooks/controllers/controllerPreferredService.ts 85% <0%> (-1%) ⬇️
...els/raw/finder/pythonKernelInterruptDaemon.node.ts 20% <0%> (-1%) ⬇️
src/kernels/raw/launcher/kernelProcess.node.ts 73% <0%> (-1%) ⬇️
... and 15 more

@IanMatthewHuff IanMatthewHuff merged commit ca5b214 into main Oct 5, 2022
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/removeInsidersNotification branch October 5, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why are you prompting to get people on pre-release?
4 participants