fix interactive window restore

[amunger]

Fixes #11574
part of #10808

• Most of the restoration is done just by recovering the editor, the controller is automatically selected.
• We need to make sure the events are all hooked up correctly even if no cells are run in the IW. (closing the IW should remove it from the list of windows)
• Get the editor information from the windows API instead of calling an API that might end up creating a new one.
  • If the editor is closed before the extension does it's restore logic, we don't want to restore that editor

[codecov-commenter]

Codecov Report

Merging #11575 (5a20e5c) into main (a9dd309) will increase coverage by 0%.
The diff coverage is 41%.

@@           Coverage Diff           @@
##            main   #11575    +/-   ##
=======================================
  Coverage     62%      62%            
=======================================
  Files        482      486     +4     
  Lines      34464    34594   +130     
  Branches    5602     5614    +12     
=======================================
+ Hits       21634    21732    +98     
- Misses     10763    10790    +27     
- Partials    2067     2072     +5     

Impacted Files	Coverage Δ
src/interactive-window/types.ts	100% <ø> (ø)
...rc/interactive-window/interactiveWindowProvider.ts	75% <12%> (-3%)	⬇️
src/interactive-window/interactiveWindow.ts	74% <48%> (-2%)	⬇️
src/platform/errors/sessionDisposedError.ts	60% <0%> (-40%)	⬇️
...s/controllers/kernelRanking/kernelRankingHelper.ts	70% <0%> (-9%)	⬇️
src/kernels/kernelProvider.base.ts	89% <0%> (-7%)	⬇️
src/notebooks/debugger/debuggingManagerBase.ts	66% <0%> (-6%)	⬇️
.../kernels/jupyter/jupyterUriProviderRegistration.ts	81% <0%> (-4%)	⬇️
src/kernels/raw/session/rawJupyterSession.node.ts	80% <0%> (-3%)	⬇️
src/kernels/kernelAutoReConnectMonitor.ts	79% <0%> (-2%)	⬇️
... and 34 more

[amunger]

this event is what sets the controller on restore. It is called even when the controller is initially set, and will also take care of the case that the user changes the controller before running any cells

[rebornix]

I'm afraid that checking visibleNotebookEditors might not work with hidden IW tabs.

[rebornix]

It looks good to me. Only nit about typings check.

[rebornix]

Would this change the typing to notebookDocument: NotebookDocument | undefined?

[amunger]

It actually was already that, but I suppose I should go through with the rest of the corrections for that

[amunger]

I think I'd rather tackle this in debt week - there is a lot of code in InteractiveWindow that relies on notebookDocument not being null, which would add a lot of extra undefined checking. Now that I've poked around quite a bit this iteration, I have a better idea of what could be done, including not relying on the editor to be the same throughout the lifetime of the IW object (separate issue).

[rebornix]

We can probably use some typescript type checking trick here since notebookDocument can be undefined:

interface IResolvedInteractiveWindow {
    notebookDocument: NotebookDocument;
}

class InteractiveWindow {
    ensureInitialized(): this is IResolvedInteractiveWindow;
}