Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move event handlers out #14078

Merged
merged 1 commit into from
Aug 8, 2023
+5 −6
Merged

Move event handlers out #14078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/kernels/jupyter/finder/remoteKernelFinderController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,17 +43,16 @@ export class RemoteKernelFinderController implements IExtensionSyncActivationSer
) {}

activate() {
// Check for when more URIs are added
this.serverUriStorage.onDidAdd(this.createRemoteKernelFinder, this, this.disposables);

// Also check for when a URI is removed
this.serverUriStorage.onDidRemove(this.urisRemoved, this, this.disposables);
// Add in the URIs that we already know about
this.serverUriStorage
.getAll()
.then((currentServers) => {
currentServers.forEach(this.createRemoteKernelFinder.bind(this));

// Check for when more URIs are added
this.serverUriStorage.onDidAdd(this.createRemoteKernelFinder, this, this.disposables);

// Also check for when a URI is removed
this.serverUriStorage.onDidRemove(this.urisRemoved, this, this.disposables);
})
.catch(noop);
}
Expand Down